831712 - Add TBPL support for ASan builds

Status: RESOLVED FIXED

(Tree Management Graveyard :: TBPL, defect)

Description

[Ed Morley [:emorley]]

These were switched on in bug 753148.

Comment 1

[Ed Morley [:emorley]]

Example builder names:
Linux x86-64 mozilla-central ASan build
Linux x86-64 mozilla-central Debug ASan build
Linux x86-64 mozilla-central ASan nightly
Linux x86-64 mozilla-central Debug ASan nightly

Comment 2

[Ed Morley [:emorley]]

Attachment: Patch v1

Somewhat torn as to what character(s) to chose for ASan builds.

Matching the B2G format would give Ba and Na; but Valgrind, Xulrunner and everything else NPOTDB doesn't use that, and it's going to end up a see of differing "B" and "N" suffixes if we're not careful.

If you have any other preference, I'm all ears - otherwise we can just land this to add support for now, and think about a more unified symbol system for TBPL v2.

Comment 3

[Chris AtLee [:catlee]]

So we could end up with "A", "An" for the various different platforms?

Comment 4

[Ed Morley [:emorley]]

The other oddities (Valgrind, xulrunner, spidermonkey etc) don't do nightly builds currently, but pretty much yes.

Comment 5

[Ed Morley [:emorley]]

(Landing blocked on me having a working machine + ssh key)

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/webtools/tbpl/rev/8ca57c333344

Comment 7

[Ed Morley [:emorley]]

In production.

Comment 8

[David Bolter [:davidb] (NeedInfo me for attention)]

\o/