831733 - GC: Transplant jsapi test (testBug604087) fails with rooting analysis

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Comment 1

[Jon Coppeard (:jonco)]

Attachment: Proposed fix

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 703341 [details] [diff] [review]
Proposed fix

Review of attachment 703341 [details] [diff] [review]:
-----------------------------------------------------------------

Ideally we'd convert the arguments to JSCompartment::wrap to handles. That seems like a lot of work, and I think evilpies might be working on it. This looks good for now.

Comment 3

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Tom, weren't you working on rooting some stuff related to wrapping?

Comment 4

[Tom S. (please needinfo tschuster)]

I started some work rooting Wrapper and Proxy, but Terrence told me that we don't want that yet. Nevertheless I just filed Bug 832299.

Comment 5

[Jon Coppeard (:jonco)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e5f0630bccc3

Comment 6

[Jon Coppeard (:jonco)]

(In reply to Tom Schuster [:evilpie] from comment #4)
Sorry if I just changed things under you :-/

Comment 7

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/e5f0630bccc3