Closed
Bug 831733
Opened 11 years ago
Closed 11 years ago
GC: Transplant jsapi test (testBug604087) fails with rooting analysis
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: jonco, Assigned: jonco)
References
Details
Attachments
(1 file)
6.08 KB,
patch
|
billm
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #703341 -
Flags: review?(wmccloskey)
Comment on attachment 703341 [details] [diff] [review] Proposed fix Review of attachment 703341 [details] [diff] [review]: ----------------------------------------------------------------- Ideally we'd convert the arguments to JSCompartment::wrap to handles. That seems like a lot of work, and I think evilpies might be working on it. This looks good for now.
Attachment #703341 -
Flags: review?(wmccloskey) → review+
Tom, weren't you working on rooting some stuff related to wrapping?
Comment 4•11 years ago
|
||
I started some work rooting Wrapper and Proxy, but Terrence told me that we don't want that yet. Nevertheless I just filed Bug 832299.
Assignee | ||
Comment 5•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/e5f0630bccc3
Assignee | ||
Comment 6•11 years ago
|
||
(In reply to Tom Schuster [:evilpie] from comment #4) Sorry if I just changed things under you :-/
Comment 7•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e5f0630bccc3
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in
before you can comment on or make changes to this bug.
Description
•