831782 - Small fixes for WebRTC mochitests

Status: RESOLVED FIXED

(Core :: WebRTC, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Before I want to continue with the next mochitests I think it would be nice to get some nits fixed. I will attach a patch in a minute.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Patch v1

This patch makes the following updates:

* removes the additional try/catch clause in the basic gum tests which is not necessary anymore given that it has been implemented in runTests() itself
* move HTML elements into the right scope (under content)
* replaces tabs with blanks

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 703343 [details] [diff] [review]
Patch v1

Review of attachment 703343 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/media/tests/mochitest/head.js
@@ +46,4 @@
>    SimpleTest.finish();
>  }
> +
> +Gozsvany
\ No newline at end of file

xyzzy ;-)
Remove this unless it's a magic incantation

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: patch v2

(In reply to Randell Jesup [:jesup] from comment #2)
> > +Gozsvany
> \ No newline at end of file
> 
> xyzzy ;-)
> Remove this unless it's a magic incantation

In the name of trust, I swear I have nothing to do with that! Something fooled me here. Thanks for catching it. Taking over r+ with the removal of the magic formula.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 703571 [details] [diff] [review]
patch v2

https://hg.mozilla.org/integration/mozilla-inbound/rev/f8bd1beec0f3

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/f8bd1beec0f3