Closed Bug 831782 Opened 7 years ago Closed 7 years ago

Small fixes for WebRTC mochitests

Categories

(Core :: WebRTC, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla21

People

(Reporter: whimboo, Assigned: whimboo)

Details

(Whiteboard: [WebRTC][qa-])

Attachments

(1 file, 1 obsolete file)

Before I want to continue with the next mochitests I think it would be nice to get some nits fixed. I will attach a patch in a minute.
Attached patch Patch v1 (obsolete) — Splinter Review
This patch makes the following updates:

* removes the additional try/catch clause in the basic gum tests which is not necessary anymore given that it has been implemented in runTests() itself
* move HTML elements into the right scope (under content)
* replaces tabs with blanks
Attachment #703343 - Flags: review?(rjesup)
Comment on attachment 703343 [details] [diff] [review]
Patch v1

Review of attachment 703343 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/media/tests/mochitest/head.js
@@ +46,4 @@
>    SimpleTest.finish();
>  }
> +
> +Gozsvany
\ No newline at end of file

xyzzy ;-)
Remove this unless it's a magic incantation
Attachment #703343 - Flags: review?(rjesup) → review+
Attached patch patch v2Splinter Review
(In reply to Randell Jesup [:jesup] from comment #2)
> > +Gozsvany
> \ No newline at end of file
> 
> xyzzy ;-)
> Remove this unless it's a magic incantation

In the name of trust, I swear I have nothing to do with that! Something fooled me here. Thanks for catching it. Taking over r+ with the removal of the magic formula.
Attachment #703343 - Attachment is obsolete: true
Attachment #703571 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/f8bd1beec0f3
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
Whiteboard: [WebRTC] → [WebRTC][qa-]
You need to log in before you can comment on or make changes to this bug.