Closed
Bug 831788
Opened 12 years ago
Closed 12 years ago
gaia-central and gaia nightly b2g builds should upload to different locations
Categories
(Release Engineering :: General, defect, P1)
Tracking
(b2g18 fixed, b2g18-v1.0.0 fixed)
RESOLVED
FIXED
People
(Reporter: armenzg, Assigned: armenzg)
References
Details
(Whiteboard: [leave open] fixed on mozilla-b2g18 and mozilla-b2g18_v1_0_0)
Attachments
(2 files, 2 obsolete files)
612 bytes,
patch
|
mozilla
:
review+
overholt
:
approval-mozilla-b2g18+
armenzg
:
checked-in+
|
Details | Diff | Splinter Review |
942 bytes,
patch
|
mozilla
:
review+
armenzg
:
checked-in+
|
Details | Diff | Splinter Review |
Currently they both upload to "-panda". This requires fixing in here: http://hg.mozilla.org/build/mozharness/file/default/scripts/b2g_build.py#l801
Comment 1•12 years ago
|
||
Maybe upload_path = gecko_config.get('upload_path', "%(basepath)s/%(user)s-%(rev)s/%(branch)s-%(target)s" % dict( ... ?
Assignee | ||
Comment 2•12 years ago
|
||
I was trying this.
Assignee | ||
Updated•12 years ago
|
Priority: -- → P2
Assignee | ||
Comment 3•12 years ago
|
||
Upload locations: http://pvtbuilds.pvt.build.mozilla.org/pub/mozilla.org/b2g/tinderbox-builds/ash-panda/20130121064520/ http://pvtbuilds.pvt.build.mozilla.org/pub/mozilla.org/b2g/tinderbox-builds/ash-panda_gaia_central/20130121064520/ I will test all builds as well just in case: https://tbpl.mozilla.org/?tree=Ash&rev=425835f6a9e2
Attachment #703375 -
Attachment is obsolete: true
Assignee | ||
Updated•12 years ago
|
Attachment #704685 -
Flags: review?(aki)
Comment 4•12 years ago
|
||
(In reply to Armen Zambrano G. [:armenzg] from comment #3) > I will test all builds as well just in case: > https://tbpl.mozilla.org/?tree=Ash&rev=425835f6a9e2 Hah, you pushed a DONTBUILD rev :)
Comment 5•12 years ago
|
||
Comment on attachment 704685 [details] [diff] [review] b2g panda builds uploaded to different locations Maybe instead of calling it 'platform', full_platform or platform_name or something, since we're appending to it? Also, actual testing would make me happy here.
Attachment #704685 -
Flags: review?(aki) → review+
Assignee | ||
Comment 6•12 years ago
|
||
Lucky me! :) Trying with https://tbpl.mozilla.org/?tree=Ash&rev=e9f39220b8e7
Assignee | ||
Comment 7•12 years ago
|
||
I will take platform_name. It worked: http://pvtbuilds2.dmz.scl3.mozilla.com//pub/mozilla.org/b2g/tinderbox-builds/ash-panda/20130123062657 http://pvtbuilds2.dmz.scl3.mozilla.com//pub/mozilla.org/b2g/tinderbox-builds/ash-panda_gaia_central/20130123062657
Assignee | ||
Updated•12 years ago
|
Attachment #704685 -
Flags: checked-in+
Assignee | ||
Comment 8•12 years ago
|
||
Builds and tests on Cedar look fine after this change.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment 9•12 years ago
|
||
I think this changed the path for unagi builds on mozilla-b2g18 from https://pvtbuilds.mozilla.org/pub/mozilla.org/b2g/nightly/mozilla-b2g18-unagi_betatest/ to https://pvtbuilds.mozilla.org/pub/mozilla.org/b2g/nightly/mozilla-b2g18-unagi_stable_betatest/ was that expected?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 10•12 years ago
|
||
Not expected but not entirely surprising either. Is that breaking anything?
Assignee | ||
Comment 11•12 years ago
|
||
Comment on attachment 704685 [details] [diff] [review] b2g panda builds uploaded to different locations Backed out: http://hg.mozilla.org/build/mozharness/rev/113656bc205b
Attachment #704685 -
Flags: checked-in+ → checked-in-
Comment 12•12 years ago
|
||
As mentioned in IRC, instead of automatically appending target suffix, we can .get("upload_platform") or something currently nonexistent, and create that key for panda-gaia-central.
Assignee | ||
Updated•12 years ago
|
Priority: P2 → P1
Assignee | ||
Comment 13•12 years ago
|
||
Assignee | ||
Comment 14•12 years ago
|
||
Testing on Ash: https://tbpl.mozilla.org/?tree=Ash&rev=13c688b34570 https://hg.mozilla.org/projects/ash/rev/13c688b34570 http://hg.mozilla.org/users/asasaki_mozilla.com/ash-mozharness/rev/0718dc9db809
Attachment #704685 -
Attachment is obsolete: true
Assignee | ||
Comment 15•12 years ago
|
||
I had to re-trigger the panda jobs because I did not merge to production. I will re-trigger the emulator and unagi jobs to make sure it works. http://pvtbuilds.pvt.build.mozilla.org/pub/mozilla.org/b2g/tinderbox-builds/ash-panda/20130129073153/ http://pvtbuilds.pvt.build.mozilla.org/pub/mozilla.org/b2g/tinderbox-builds/ash-panda_gaia_central/20130129073153/
Assignee | ||
Updated•12 years ago
|
Attachment #707631 -
Flags: review?(aki)
Assignee | ||
Updated•12 years ago
|
Attachment #707632 -
Flags: review?(aki)
Assignee | ||
Comment 16•12 years ago
|
||
The remaining upload paths are working: http://ftp.mozilla.org/pub/mozilla.org/b2g/tinderbox-builds/ash-ics_armv7a_gecko/1359473513 http://ftp.mozilla.org/pub/mozilla.org/b2g/tinderbox-builds/ash-ics_armv7a_gecko-debug/1359473513 Unagi builds don't upload.
Comment 17•12 years ago
|
||
Comment on attachment 707631 [details] [diff] [review] m-c - add upload_platform to b2g/config/panda-gaia-central.json This'll have to land in all branches where we build panda_gaia_central.
Attachment #707631 -
Flags: review?(aki) → review+
Comment 18•12 years ago
|
||
Comment on attachment 707632 [details] [diff] [review] take upload_platform into consideration if specified on the config.json for such target This could be target = self.load_gecko_config().get('upload_platform', self.config['target']) This is fine, though. Glad to see some smaller patches from you :)
Attachment #707632 -
Flags: review?(aki) → review+
Assignee | ||
Comment 19•12 years ago
|
||
Comment on attachment 707631 [details] [diff] [review] m-c - add upload_platform to b2g/config/panda-gaia-central.json http://hg.mozilla.org/integration/mozilla-inbound/rev/fd83646a2d15
Attachment #707631 -
Flags: checked-in+
Assignee | ||
Comment 20•12 years ago
|
||
Comment on attachment 707632 [details] [diff] [review] take upload_platform into consideration if specified on the config.json for such target I like your suggestion. I've taken it.
Attachment #707632 -
Flags: checked-in+
Assignee | ||
Comment 21•12 years ago
|
||
I will leave this open until we merge mozharness to production and land the patch on all relevant b2g branches.
Assignee | ||
Updated•12 years ago
|
Whiteboard: it needs to land on appropriate b2g branches
Assignee | ||
Comment 22•12 years ago
|
||
I assume I need to land it to Mozilla-B2g18 and Mozilla-B2g18_v1_0_0. All other branches will be able to get fixed once pulling from m-c.
Assignee | ||
Comment 23•12 years ago
|
||
Comment on attachment 707631 [details] [diff] [review] m-c - add upload_platform to b2g/config/panda-gaia-central.json [Approval Request Comment] Currently we create two b2g builds for the panda boards. One based off gaia nightly and the other from gaia central. We currently upload both to the same location and overwrite each other. This patch will allow to specify a different upload location for the gaia central job. I need to land this on mozilla-b2g18 and mozilla-b2g18_v1_0_0. Any other branches besides those two?
Attachment #707631 -
Flags: approval-mozilla-b2g18?
Comment 24•12 years ago
|
||
Comment on attachment 707632 [details] [diff] [review] take upload_platform into consideration if specified on the config.json for such target Merged to production. Should be noop until upload_platform is specified in-tree.
Assignee | ||
Comment 25•12 years ago
|
||
It is working on inbound: http://pvtbuilds.pvt.build.mozilla.org//pub/mozilla.org/b2g/tinderbox-builds/mozilla-inbound-panda http://pvtbuilds.pvt.build.mozilla.org//pub/mozilla.org/b2g/tinderbox-builds/mozilla-inbound-panda_gaia_central
Whiteboard: it needs to land on appropriate b2g branches → [leave open] it needs to land on appropriate b2g branches
Updated•12 years ago
|
Attachment #707631 -
Flags: approval-mozilla-b2g18? → approval-mozilla-b2g18+
Assignee | ||
Comment 26•12 years ago
|
||
https://hg.mozilla.org/releases/mozilla-b2g18/rev/57ac7f8d6db0 https://hg.mozilla.org/releases/mozilla-b2g18_v1_0_0/rev/61de17fa9289
Status: REOPENED → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → FIXED
Whiteboard: [leave open] it needs to land on appropriate b2g branches → [leave open] fixed on mozilla-b2g18 and mozilla-b2g18_v1_0_0
Assignee | ||
Updated•12 years ago
|
status-b2g18:
--- → fixed
status-b2g18-v1.0.0:
--- → fixed
Whiteboard: [leave open] fixed on mozilla-b2g18 and mozilla-b2g18_v1_0_0
Comment 27•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/fd83646a2d15
Whiteboard: [leave open] fixed on mozilla-b2g18 and mozilla-b2g18_v1_0_0
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
Updated•7 years ago
|
Component: General Automation → General
You need to log in
before you can comment on or make changes to this bug.
Description
•