831883 - eliminate the Open Sans fonts bundled in the Reader core theme, just use Gecko's "installed" copy

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Reader View, defect)

Description

[Jonathan Kew [:jfkthame]]

In bug 831354, we're shipping Open Sans as the default sans-serif font for Firefox on Android, by including it in the package. This will make it appear as just another installed font on the platform, as far as the rest of Gecko is concerned.

As a result, we can remove the use of @font-face to explicitly load Open Sans from chrome:// URIs in the Reader CSS; it can simply refer to the installed font by name. This will reduce the overhead of starting up a Reader view.

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: eliminate the copy of Open Sans fonts bundled in the Reader core theme.

remove-reader-fonts

Comment 2

[Jonathan Kew [:jfkthame]]

Oops, sorry about the unhelpful comment - I messed up with bzexport. Anyway, with bug 831354 landed on trunk, we can now claw back some of the size increase there by removing the Reader copy of the fonts, as they're now available throughout the platform in the regular font list. This also saves us going through the process of loading and sanitizing the font files and instantiating new platform font objects each time the user enters Reader mode.

Comment 3

[Lucas Rocha (:lucasr)]

Comment on attachment 704357 [details] [diff] [review]
eliminate the copy of Open Sans fonts bundled in the Reader core theme.

Review of attachment 704357 [details] [diff] [review]:
-----------------------------------------------------------------

Nice. Will this also fix bug 792370 somehow?

Comment 4

[Jonathan Kew [:jfkthame]]

(In reply to Lucas Rocha (:lucasr) from comment #3)

> Nice. Will this also fix bug 792370 somehow?

Yup, should do, as we have a more complete set of styles in the platform now.

Comment 5

[Jonathan Kew [:jfkthame]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/595daefc448c

Comment 6

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/595daefc448c