Closed Bug 832015 Opened 12 years ago Closed 12 years ago

Use 2x private browsing titlebar mask image in HiDPI mode

Categories

(Firefox :: Theme, defect)

Product:
Firefox
Component:
Theme
Platform:
All
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 21
Tracking Flags:
Tracking Status
firefox19 --- unaffected
firefox20 + fixed

People

(Reporter: fryn, Assigned: fryn)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

patch
5.70 KB, patch
shorlander
: review+
bajaj
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
      No description provided.
What needs to be done here?  I'm not sure I understand the bug.
Summary: Use 2x private browsing mask image in HiDPI mode → Use 2x private browsing titlebar mask image in HiDPI mode
Attached patch patch — — Splinter Review 

        Attachment #703619 -
        Flags: review?(shorlander)

        Attachment #703619 -
        Flags: review?(shorlander) → review+

    
    

    
  
https://hg.mozilla.org/integration/mozilla-inbound/rev/229aebf6428e
Target Milestone: --- → Firefox 21

    
    

    
  
Tracking to make sure we uplift this change, in support of HiDPI and our new feature.

          status-firefox19:
          --- → unaffected

          status-firefox20:
          --- → affected

          tracking-firefox20:
          ? → +

    
  

        Attachment #703619 -
        Flags: approval-mozilla-aurora?

    
    

    
  
Comment on attachment 703619 [details] [diff] [review]
patch

(In reply to Alex Keybl [:akeybl] from comment #4)
> Tracking to make sure we uplift this change, in support of HiDPI and our new
> feature.

This is a CSS-only change that simply replaces a small background-image with a higher-resolution image for users using high-dpi displays on OS X. The risk is very small and isolated to that set of users.

Nominating for aurora approval as per akeybl's above comment.

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/229aebf6428e
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED

    
    

    
  
Comment on attachment 703619 [details] [diff] [review]
patch

Approving on aurora.Low risk patch in support of HiDPI and our new feature .

        Attachment #703619 -
        Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

    
  
Depends on: 834225

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: