The default bug view has changed. See this FAQ.

Measure JSRuntime::bumpAlloc_ in the JS memory reporter.

RESOLVED FIXED in mozilla21

Status

()

Core
JavaScript Engine
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: njn, Assigned: njn)

Tracking

unspecified
mozilla21
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [MemShrink])

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
We don't measure the mmaps done by JSRuntime::bumpAlloc_.
(Assignee)

Comment 1

4 years ago
Created attachment 703602 [details] [diff] [review]
Measure JSRuntime::bumpAlloc_ in the JS memory reporter.

This patch measures JSRuntime::bumpAlloc_.  I haven't seen it go higher than 4
KiB, but we want to have complete coverage of all the mmap calls done by
Firefox, so it's worth having just for that reason.  Also, it's possible that
it could go higher in rare cases.
Attachment #703602 - Flags: review?(sstangl)
(Assignee)

Updated

4 years ago
Whiteboard: [MemShrink]
Comment on attachment 703602 [details] [diff] [review]
Measure JSRuntime::bumpAlloc_ in the JS memory reporter.

Review of attachment 703602 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jscntxt.cpp
@@ +155,5 @@
>      }
>  
> +    if (bumpAlloc_) {
> +        n += bumpAlloc_->sizeOfNonHeapData();
> +    }

uber-nit: no need for braces in single-line if()
Attachment #703602 - Flags: review?(sstangl) → review+
(Assignee)

Comment 3

4 years ago
Thanks for the fast review.


> uber-nit: no need for braces in single-line if()

Going back and forth between JS and Gecko styles is such a delight.
(Assignee)

Comment 4

4 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/4f0b7a4daacf
https://hg.mozilla.org/mozilla-central/rev/4f0b7a4daacf
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.