Closed Bug 832026 Opened 7 years ago Closed 7 years ago

Measure JSRuntime::bumpAlloc_ in the JS memory reporter.

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla21

People

(Reporter: njn, Assigned: njn)

Details

(Whiteboard: [MemShrink])

Attachments

(1 file)

We don't measure the mmaps done by JSRuntime::bumpAlloc_.
This patch measures JSRuntime::bumpAlloc_.  I haven't seen it go higher than 4
KiB, but we want to have complete coverage of all the mmap calls done by
Firefox, so it's worth having just for that reason.  Also, it's possible that
it could go higher in rare cases.
Attachment #703602 - Flags: review?(sstangl)
Whiteboard: [MemShrink]
Comment on attachment 703602 [details] [diff] [review]
Measure JSRuntime::bumpAlloc_ in the JS memory reporter.

Review of attachment 703602 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jscntxt.cpp
@@ +155,5 @@
>      }
>  
> +    if (bumpAlloc_) {
> +        n += bumpAlloc_->sizeOfNonHeapData();
> +    }

uber-nit: no need for braces in single-line if()
Attachment #703602 - Flags: review?(sstangl) → review+
Thanks for the fast review.


> uber-nit: no need for braces in single-line if()

Going back and forth between JS and Gecko styles is such a delight.
https://hg.mozilla.org/mozilla-central/rev/4f0b7a4daacf
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.