832154 - Convert SVGMarkerElement to WebIDL

Status: RESOLVED FIXED

(Core :: SVG, defect)

Comment 1

[David Zbarsky (:dzbarsky)]

Attachment: move SVGMarkerElement to mozilla::dom

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 704761 [details] [diff] [review]
move SVGMarkerElement to mozilla::dom

>-typedef mozilla::dom::SVGGraphicsElement nsSVGMarkerElementBase;
>+typedef nsSVGElement SVGMarkerElementBase;

Why the change of base class here?

Comment 3

[David Zbarsky (:dzbarsky)]

(In reply to Boris Zbarsky (:bz) from comment #2)
> Comment on attachment 704761 [details] [diff] [review]
> Why the change of base class here?

Hmm, looks like marker has inherited from SVGGraphicsElement since we first implemented markers. It inherits from SVGElement in SVG1.1 and SVG2, and we never exposed SVGLocatable, SVGTransformable, or SVGTests on it in classinfo. (http://hg.mozilla.org/mozilla-central/file/7a8cc4687e5e/dom/src/base/nsDOMClassInfo.cpp)

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 704761 [details] [diff] [review]
move SVGMarkerElement to mozilla::dom

> It inherits from SVGElement in SVG1.1 and SVG2

So the point is that there is no actual behavior change here?

Sounds plausible, but I'd like longsonr OK that.

Comment 5

[Robert Longson [:longsonr]]

Comment on attachment 704761 [details] [diff] [review]
move SVGMarkerElement to mozilla::dom

Seems OK to me.

Comment 6

[David Zbarsky (:dzbarsky)]

Attachment: Convert SVGMarkerElement to webidl

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 706918 [details] [diff] [review]
Convert SVGMarkerElement to webidl

>+  if (!NS_finite(f)) {
>+    rv.Throw(NS_ERROR_DOM_SVG_WRONG_TYPE_ERR);
>+  }

You need to return in there too, no?

r=me with that fixed

Comment 8

[David Zbarsky (:dzbarsky)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0559d630dd89
https://hg.mozilla.org/integration/mozilla-inbound/rev/dfc9d5651175

Comment 9

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Backed out for Windows bustage. https://hg.mozilla.org/integration/mozilla-inbound/rev/2b9ae5e6cd9b
https://tbpl.mozilla.org/php/getParsedLog.php?id=19230027&tree=Mozilla-Inbound

Comment 10

[David Zbarsky (:dzbarsky)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/46df7f312c62
https://hg.mozilla.org/integration/mozilla-inbound/rev/3648eab2b51c

Comment 11

[(Out Sep 17-23) Ryan VanderMeulen]

https://hg.mozilla.org/mozilla-central/rev/46df7f312c62
https://hg.mozilla.org/mozilla-central/rev/3648eab2b51c