Closed Bug 832154 Opened 7 years ago Closed 7 years ago

Convert SVGMarkerElement to WebIDL

Categories

(Core :: SVG, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla21

People

(Reporter: dzbarsky, Assigned: dzbarsky)

References

Details

Attachments

(2 files)

No description provided.
Assignee: nobody → dzbarsky
Status: NEW → ASSIGNED
Attachment #704761 - Flags: review?(bzbarsky)
Comment on attachment 704761 [details] [diff] [review]
move SVGMarkerElement to mozilla::dom

>-typedef mozilla::dom::SVGGraphicsElement nsSVGMarkerElementBase;
>+typedef nsSVGElement SVGMarkerElementBase;

Why the change of base class here?
(In reply to Boris Zbarsky (:bz) from comment #2)
> Comment on attachment 704761 [details] [diff] [review]
> Why the change of base class here?

Hmm, looks like marker has inherited from SVGGraphicsElement since we first implemented markers. It inherits from SVGElement in SVG1.1 and SVG2, and we never exposed SVGLocatable, SVGTransformable, or SVGTests on it in classinfo. (http://hg.mozilla.org/mozilla-central/file/7a8cc4687e5e/dom/src/base/nsDOMClassInfo.cpp)
Comment on attachment 704761 [details] [diff] [review]
move SVGMarkerElement to mozilla::dom

> It inherits from SVGElement in SVG1.1 and SVG2

So the point is that there is no actual behavior change here?

Sounds plausible, but I'd like longsonr OK that.
Attachment #704761 - Flags: review?(longsonr)
Attachment #704761 - Flags: review?(bzbarsky)
Attachment #704761 - Flags: review+
Comment on attachment 704761 [details] [diff] [review]
move SVGMarkerElement to mozilla::dom

Seems OK to me.
Attachment #704761 - Flags: review?(longsonr) → review+
Attachment #706918 - Flags: review?(bzbarsky)
Comment on attachment 706918 [details] [diff] [review]
Convert SVGMarkerElement to webidl

>+  if (!NS_finite(f)) {
>+    rv.Throw(NS_ERROR_DOM_SVG_WRONG_TYPE_ERR);
>+  }

You need to return in there too, no?

r=me with that fixed
Attachment #706918 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/46df7f312c62
https://hg.mozilla.org/mozilla-central/rev/3648eab2b51c
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.