Closed
Bug 832154
Opened 11 years ago
Closed 11 years ago
Convert SVGMarkerElement to WebIDL
Categories
(Core :: SVG, defect)
Core
SVG
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: dzbarsky, Assigned: dzbarsky)
References
Details
Attachments
(2 files)
27.25 KB,
patch
|
bzbarsky
:
review+
longsonr
:
review+
|
Details | Diff | Splinter Review |
14.71 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•11 years ago
|
||
Comment 2•11 years ago
|
||
Comment on attachment 704761 [details] [diff] [review] move SVGMarkerElement to mozilla::dom >-typedef mozilla::dom::SVGGraphicsElement nsSVGMarkerElementBase; >+typedef nsSVGElement SVGMarkerElementBase; Why the change of base class here?
Assignee | ||
Comment 3•11 years ago
|
||
(In reply to Boris Zbarsky (:bz) from comment #2) > Comment on attachment 704761 [details] [diff] [review] > Why the change of base class here? Hmm, looks like marker has inherited from SVGGraphicsElement since we first implemented markers. It inherits from SVGElement in SVG1.1 and SVG2, and we never exposed SVGLocatable, SVGTransformable, or SVGTests on it in classinfo. (http://hg.mozilla.org/mozilla-central/file/7a8cc4687e5e/dom/src/base/nsDOMClassInfo.cpp)
Comment 4•11 years ago
|
||
Comment on attachment 704761 [details] [diff] [review] move SVGMarkerElement to mozilla::dom > It inherits from SVGElement in SVG1.1 and SVG2 So the point is that there is no actual behavior change here? Sounds plausible, but I'd like longsonr OK that.
Attachment #704761 -
Flags: review?(longsonr)
Attachment #704761 -
Flags: review?(bzbarsky)
Attachment #704761 -
Flags: review+
Comment 5•11 years ago
|
||
Comment on attachment 704761 [details] [diff] [review] move SVGMarkerElement to mozilla::dom Seems OK to me.
Attachment #704761 -
Flags: review?(longsonr) → review+
Assignee | ||
Comment 6•11 years ago
|
||
Attachment #706918 -
Flags: review?(bzbarsky)
Comment 7•11 years ago
|
||
Comment on attachment 706918 [details] [diff] [review] Convert SVGMarkerElement to webidl >+ if (!NS_finite(f)) { >+ rv.Throw(NS_ERROR_DOM_SVG_WRONG_TYPE_ERR); >+ } You need to return in there too, no? r=me with that fixed
Attachment #706918 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Comment 8•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/0559d630dd89 https://hg.mozilla.org/integration/mozilla-inbound/rev/dfc9d5651175
Backed out for Windows bustage. https://hg.mozilla.org/integration/mozilla-inbound/rev/2b9ae5e6cd9b https://tbpl.mozilla.org/php/getParsedLog.php?id=19230027&tree=Mozilla-Inbound
Assignee | ||
Comment 10•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/46df7f312c62 https://hg.mozilla.org/integration/mozilla-inbound/rev/3648eab2b51c
Comment 11•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/46df7f312c62 https://hg.mozilla.org/mozilla-central/rev/3648eab2b51c
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in
before you can comment on or make changes to this bug.
Description
•