Closed
Bug 832202
Opened 13 years ago
Closed 13 years ago
buildconfig.py fails when config.status contains empty lists
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla21
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(1 file)
|
1.11 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
On comm-central, the headers list is empty, and this makes buildconfig.py fail.
|
Assignee | |
Comment 1•13 years ago
|
||
Note the patch probably doesn't apply on m-c because of the context which depends on bug 780561, but the modified part doesn't depend on bug 780561.
Attachment #703814 -
Flags: review?(ted)
|
|
Assignee | |
Updated•13 years ago
|
Blocks: new-packager
|
||
Comment 2•13 years ago
|
||
Comment on attachment 703814 [details] [diff] [review]
Handle empty lists from config.status in buildconfig.py
Review of attachment 703814 [details] [diff] [review]:
-----------------------------------------------------------------
::: build/buildconfig.py
@@ +20,5 @@
> # This effectively imports topsrcdir, topobjdir, defines, substs, files,
> # headers and non_global_defines
> for var in config.__all__:
> value = getattr(config, var)
> + if isinstance(value, list) and len(value) and isinstance(value[0], tuple):
I'd prefer if the middle test was either just "value" or "len(value) > 0".
Attachment #703814 -
Flags: review?(ted) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
|
||
Comment 4•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
|
||
Updated•8 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•