832231 - After a reload, breakpoints require multiple resumes to allow execution to continue

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P2)

Description

[Victor Porof [:vporof][:vp]]

STR:

1. Open debugger on http://htmlpad.org/debugger/
2. Add a breakpoint on line 12
3. Click me

It takes 1 resume to get to line 13.
You can resume until the script finishes executing, or jump directly to 4.

4. Reload page
5. Click me

It takes 3 resumes to get to line 13.
The debugger frontend doesn't make any setBreakpoint requests after reload.

Comment 1

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Patch v1

The problem was that _addScript was being called by both onNewScript (each time a script appeared) and onSources (each time the frontend requested the available scripts), but it didn't keep tabs on how many times it tried to set a breakpoint on the associated script(s). On a tangentially-related issue, we didn't actually severe the breakpoint actor - script association when a page navigation occurred, which would lead to a small memory leak while the debugger was open.

This patch fixes both, passes all tests, but needs a new one.

Comment 2

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Test WIP

This is a test that... works, even when it shouldn't (i.e. without the fix applied). I'll fix it tomorrow and qfold it back to the main patch.

Comment 3

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Patch v2

The test now works as advertised.

Try run: https://tbpl.mozilla.org/?tree=Try&rev=07310018cd1a

Comment 4

[Victor Porof [:vporof][:vp]]

Comment on attachment 744137 [details] [diff] [review]
Patch v2

Review of attachment 744137 [details] [diff] [review]:
-----------------------------------------------------------------

Loving it!

Comment 5

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/integration/fx-team/rev/f14297265cba

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/f14297265cba