832280 - Disable MSVC warning C4482: nonstandard extension used: enum 'xyz' used in qualified name

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[filidautore]

It becomes a standard since C++11, and MSVC11 removed the warning.
(See bug 755031 comment 23 and 24)

Comment 1

[filidautore]

Attachment: Disable globally MSVC warning C4482

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 703869 [details] [diff] [review]
Disable globally MSVC warning C4482

Review of attachment 703869 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +2201,5 @@
>          # MSVC warning C4345 warns of newly conformant behavior as of VS2003.
>          # MSVC warning C4351 warns of newly conformant behavior as of VS2005.
> +        # MSVC warning C4482 warns when an enum value is refered specifing the
> +        # name of the enum itself.  It becomes a standard since C++11, and MSVC11
> +        # removed the warning.

Can you reword this slightly, perhaps "This behavior is allowed in C++11, and the warning has been removed in VS2012."

Comment 3

[(not currently active) Ted Mielczarek]

If you can upload a patch with that minor rewording, you can add the "checkin-needed" keyword to this bug and we'll get it landed. Thanks for the patch!

Comment 4

[filidautore]

Attachment: Disable globally MSVC warning C4482 - v1.1

Updated the comment in the patch as suggested.

Comment 5

[filidautore]

(In reply to Ted Mielczarek [:ted.mielczarek] from comment #3)
Thanks to you for fast review :)

Comment 6

[Masatoshi Kimura [:emk]]

Thanks for proofing my poor English :)
https://hg.mozilla.org/integration/mozilla-inbound/rev/8472e5898021

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8472e5898021

Comment 8

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Doing this still causes build errors for people, no?

Comment 9

[Masatoshi Kimura [:emk]]

What build errors?

Comment 10

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

jgriffin had a build issue because of a gfxImageFormat:: prefix on mac on Jan 8, but the pastebin is dead already.

Comment 11

[Masatoshi Kimura [:emk]]

Obviously this patch will affect only MSVC.
A better fix would be making gfxImageFormat an enum class as dholbert said.