Closed Bug 832280 Opened 7 years ago Closed 7 years ago

Disable MSVC warning C4482: nonstandard extension used: enum 'xyz' used in qualified name

Categories

(Firefox Build System :: General, defect)

x86
Windows 7
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla21

People

(Reporter: filidautore, Assigned: filidautore)

Details

Attachments

(1 file, 1 obsolete file)

It becomes a standard since C++11, and MSVC11 removed the warning.
(See bug 755031 comment 23 and 24)
Attachment #703869 - Flags: review?(ted)
Assignee: nobody → filidautore
Comment on attachment 703869 [details] [diff] [review]
Disable globally MSVC warning C4482

Review of attachment 703869 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +2201,5 @@
>          # MSVC warning C4345 warns of newly conformant behavior as of VS2003.
>          # MSVC warning C4351 warns of newly conformant behavior as of VS2005.
> +        # MSVC warning C4482 warns when an enum value is refered specifing the
> +        # name of the enum itself.  It becomes a standard since C++11, and MSVC11
> +        # removed the warning.

Can you reword this slightly, perhaps "This behavior is allowed in C++11, and the warning has been removed in VS2012."
Attachment #703869 - Flags: review?(ted) → review+
If you can upload a patch with that minor rewording, you can add the "checkin-needed" keyword to this bug and we'll get it landed. Thanks for the patch!
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Updated the comment in the patch as suggested.
Attachment #703869 - Attachment is obsolete: true
Attachment #703890 - Flags: review+
Keywords: checkin-needed
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #3)
Thanks to you for fast review :)
Thanks for proofing my poor English :)
https://hg.mozilla.org/integration/mozilla-inbound/rev/8472e5898021
Flags: in-testsuite-
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/8472e5898021
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
Doing this still causes build errors for people, no?
What build errors?
jgriffin had a build issue because of a gfxImageFormat:: prefix on mac on Jan 8, but the pastebin is dead already.
Obviously this patch will affect only MSVC.
A better fix would be making gfxImageFormat an enum class as dholbert said.
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.