832336 - [Clock] Clock settings need adjustment

Status: RESOLVED DUPLICATE of bug 855426

(Firefox OS Graveyard :: Gaia::Clock, defect)

Description

[Patryk Adamczyk [:patryk] UX]

Currently if you have 5+ alarms in the list, the 5th and beyond alarm is hidden with no visual accordance added. This needs to be designed in. Also the alarm delete button feels too close to the other options, the adding / edit alarm list needs to be massaged.

Comment 1

[Patryk Adamczyk [:patryk] UX]

Eric can you please provide and updated design and send it over to pavel for implementation.

Comment 2

[Eric Pang [:epang] UX]

Attachment: Mock Up for Edit Alarm

Pavel, the edit alarm screen uses the same common control spacing spec which I'll attach to this bug as well.

Comment 3

[Eric Pang [:epang] UX]

Attachment: Common Controls Spacing Spec

Comment 4

[Lukas Blakk [:lsblakk] use ?needinfo]

If the UX team is making a case for this in v1.1 go ahead with nomination for uplift.

Comment 5

[Lukas Blakk [:lsblakk] use ?needinfo]

Mass edit to set tracking-b2g18+ for these UX bugs that were called out for v1.1

Comment 6

[Eric Pang [:epang] UX]

Hi Pavel, can you work on fixing the alarm settings with the mock ups i provided?  The second part of this bug isn't ready and I don't want this part being held back because of it.  I'll file a new bug with the second part is ready. Thanks!

Comment 7

[[e-mail], [e-mail]]

Also add Rex in mail list. He is the supported WVGA owner.

Comment 8

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: After patch

Hey Eric,
I made a lot of changes for this bug ... can you check this screenshots?

Comment 9

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch for Gaia repo

Comment 10

[[e-mail], [e-mail]]

Hi Pavel,

Thanks for your help on adjusting alarm-edit page. The style is sync with our building block. After Eric's confirmation, I will help to review the pr. Nice job!

Comment 11

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Thanks :) hope everything is ok :)

Comment 12

[Eric Pang [:epang] UX]

(In reply to Pavel Ivanov [:ivanovpavel] from comment #8)
> Created attachment 731532 [details]
> After patch
> 
> Hey Eric,
> I made a lot of changes for this bug ... can you check this screenshots?

Hi Pavel,

The New Alarm and Edit Alarm page looks great now!  Ship it! :)  
Did you make changes to the clock/alarm list as well?  Cause we haven't finalized designs for it yet, those will be coming soon (I'll create a new bug when they are ready).  So if changes were made, they need to be reverted :(. Let me know, Thanks!

Comment 13

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

I made just few small changes ... so :) waiting for the new bug :)

Comment 14

[Eric Pang [:epang] UX]

(In reply to Pavel Ivanov [:ivanovpavel] from comment #13)
> I made just few small changes ... so :) waiting for the new bug :)

ok, the settings screen looks good to me, so this fix should be ready for Sam's review. Thanks!

Comment 15

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

I just came to realize, that the alarm starts on Monday.  Not all countries start with Monday as the first day.  Some countries start their week on a sunday.  Not sure if we want to bother with that as it looks like it could be a lot of work since it's hard coded to start on monday.

Comment 16

[jachen]

I'm fine to keep this to hard coded to Monday. Not something to deal this bug getting finished.

Comment 17

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

waiting for Sam

Comment 18

[Sam Joch [:samjoch]]

Comment on attachment 731533 [details]
patch for Gaia repo

comment in github https://github.com/mozilla-b2g/gaia/pull/8895

Comment 19

[Eric Pang [:epang] UX]

(In reply to Sam Joch [:samjoch] from comment #18)
> Comment on attachment 731533 [details]
> patch for Gaia repo
> 
> comment in github https://github.com/mozilla-b2g/gaia/pull/8895

Hi Sam, is this patch ready for review?  If so, who can review? Let me know, Thanks!

Comment 20

[Sam Joch [:samjoch]]

Pavel and I just just created a bug to take care of select consistency in apps.
https://bugzilla.mozilla.org/show_bug.cgi?id=862246

We need to fix how select are used in apps but for now we need to fix this bug, Pavel is adding a reference in the code. Going to merge it.

Comment 21

[Eric Pang [:epang] UX]

(In reply to Sam Joch [:samjoch] from comment #20)
> Pavel and I just just created a bug to take care of select consistency in
> apps.
> https://bugzilla.mozilla.org/show_bug.cgi?id=862246
> 
> We need to fix how select are used in apps but for now we need to fix this
> bug, Pavel is adding a reference in the code. Going to merge it.

Hi Pavel,
What's the status on this bug?

Comment 22

[Eric Pang [:epang] UX]

(In reply to Eric Pang [:epang] from comment #21)
> (In reply to Sam Joch [:samjoch] from comment #20)
> > Pavel and I just just created a bug to take care of select consistency in
> > apps.
> > https://bugzilla.mozilla.org/show_bug.cgi?id=862246
> > 
> > We need to fix how select are used in apps but for now we need to fix this
> > bug, Pavel is adding a reference in the code. Going to merge it.
> 
> Hi Pavel,
> What's the status on this bug?

Sorry Pavel, just realized we probably need to hold on this because of the drop down selects...I want to get Sergi's opinion on our drop downs before going forward in bug 847436.  (ie, left aligned, margins, type alignment, etc).  Once a decision has been made I will update the mock up and we can move forward :).  Thanks!

Comment 23

[Eric Pang [:epang] UX]

Comment on attachment 731533 [details]
patch for Gaia repo

Sorry Sam, this isn't ready for review.  I want to get more info on drop downs before moving forward on this bug (since it uses a lot of drop down selects!)

Comment 24

[Eric Pang [:epang] UX]

(In reply to Eric Pang [:epang] from comment #22)
> (In reply to Eric Pang [:epang] from comment #21)
> > (In reply to Sam Joch [:samjoch] from comment #20)
> > > Pavel and I just just created a bug to take care of select consistency in
> > > apps.
> > > https://bugzilla.mozilla.org/show_bug.cgi?id=862246
> > > 
> > > We need to fix how select are used in apps but for now we need to fix this
> > > bug, Pavel is adding a reference in the code. Going to merge it.
> > 
> > Hi Pavel,
> > What's the status on this bug?
> 
> Sorry Pavel, just realized we probably need to hold on this because of the
> drop down selects...I want to get Sergi's opinion on our drop downs before
> going forward in bug 847436.  (ie, left aligned, margins, type alignment,
> etc).  Once a decision has been made I will update the mock up and we can
> move forward :).  Thanks!

Hi Pavel,

Sergi responded about the drop downs and says they are good.  I'll flag this to be reviewed by Sam.  Thanks!

Comment 25

[Eric Pang [:epang] UX]

Comment on attachment 731533 [details]
patch for Gaia repo

Hi Sam, this is ready for review now. Thanks!

Comment 26

[Eric Pang [:epang] UX]

Marking this bug as a duplicate since it's being taken care of in bug 855426

Comment 27

[Sam Joch [:samjoch]]

Does this need a review event if it's mark as duplicate ?
Or should Pavel need to transfert and update his patch ?

Comment 28

[Eric Pang [:epang] UX]

(In reply to Sam Joch [:samjoch] from comment #27)
> Does this need a review event if it's mark as duplicate ?
> Or should Pavel need to transfert and update his patch ?

Hi Sam, I don't think we need to review this patch specifically since it's not ready.  I've asked in the other bug if the patch should be transferred and updated by Pavel.  I've added both of you to the cc so we can see what the decision is. Thanks!