832351 - Display B2G_OS_Version on report/index (detailed report page)

Status: VERIFIED FIXED

(Socorro :: Webapp, task)

Description

[Robert Kaiser]

Where it's present in the raw JSON, we should display B2G_OS_Version on the report/index page, for the moment as "B2G OS Version" (I think we want to avoid the official banding and not display "Firefox OS Version" at least atm).

bp-ec271e9e-6700-4717-a58b-413be2130117 is one example of a report that should have it displayed.

Comment 1

[Laura Thomson :laura]

Needed sooner rather than later: let's change this in both PHP and Django.

Comment 2

[Robert Helmer [:rhelmer]]

PHP PR: https://github.com/mozilla/socorro/pull/1110

Comment 3

[Robert Helmer [:rhelmer]]

Django PR: https://github.com/mozilla/socorro-crashstats/pull/312

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro-crashstats

https://github.com/mozilla/socorro-crashstats/commit/b0dc680e9303b32b2600f9d2a46685a040e074c9
bug 832351 - expose B2G_OS_VERSION in report/index

https://github.com/mozilla/socorro-crashstats/commit/a25e9067a9100c80db6b130f2fc631a668ab74a5
Merge pull request #312 from rhelmer/bug832351-expose-b2g_os_version

bug 832351 - expose B2G_OS_VERSION in report/index

Comment 5

[Lonnen :lonnen]

kicking since this didn't land.

Comment 6

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/1cabb1661250cd36fc94a89e1b3a516c8572b560
bug 832351 - expose B2G_OS_VERSION in report/index

https://github.com/mozilla/socorro/commit/9312c2295ee1aee49724624f7d1508d2845ed708
Merge pull request #1110 from rhelmer/bug832351-expose-b2g_os_version

bug 832351 - expose B2G_OS_VERSION on report/index

Comment 7

[Robert Helmer [:rhelmer]]

Oops there is a typo in the PHP impl, will fix in one sec

Comment 8

[Robert Helmer [:rhelmer]]

https://github.com/mozilla/socorro/pull/1160

Comment 9

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/3f3a7d0b3a708d105e99cb0e649aefeadfa0722a
bug 832351 - right curly brace not endif here

https://github.com/mozilla/socorro/commit/ad4efc8b1e50b927ba65a10e847b16d4f49b2279
Merge pull request #1160 from rhelmer/bug832351-typo

bug 832351 - right curly brace not endif here

Comment 10

[Robert Kaiser]

I need to reopen, unfortunately. Neither https://crash-stats-django.mozilla.org/report/index/cf1d6f49-ceec-4e10-b342-c0b0c2130625 nor https://crash-stats.mozilla.com/report/index/cf1d6f49-ceec-4e10-b342-c0b0c2130625 show the B2G OS Version in the UI, but https://crash-stats-django.mozilla.org/rawdumps/cf1d6f49-ceec-4e10-b342-c0b0c2130625.json clearly contains it:

{
    "InstallTime": "1371416358",
    "Version": "24.0a1",
    "id": "{3c2e2abc-06d4-11e1-ac3b-374f68613e61}",
    "Android_Hardware": "qcom",
    "Vendor": "Mozilla",
    "buildid": "20130616002204",
    "version": "24.0a1",
    "CrashTime": "1372171191",
    "Android_Device": "keon",
    "Android_CPU_ABI2": "armeabi",
    "ReleaseChannel": "nightly",
    "submitted_timestamp": "2013-06-25T14:40:17.478034+00:00",
    "Android_CPU_ABI": "armeabi-v7a",
    "URL": "app://camera.gaiamobile.org/manifest.webapp",
    "timestamp": 1372171217.478063,
    "Notes": "GL Layers! EGL? EGL+ GL Context? GL Context+ GL Layers+ ",
    "Android_Manufacturer": "GEEKSPHONE",
    "Android_Brand": "qcom",
    "ProcessType": "content",
    "StartupTime": "1372171183",
    "BuildID": "20130616002204",
    "Android_Model": "GP-KEON",
    "ProductName": "B2G",
    "legacy_processing": 0,
    "Android_Version": "15(AOSP)",
    "Android_Board": "7x27",
    "B2G_OS_Version": "2.0.0.0-prerelease",
    "ProductID": "{3c2e2abc-06d4-11e1-ac3b-374f68613e61}"
}

Comment 11

[Robert Helmer [:rhelmer]]

(In reply to Robert Kaiser (:[e-mail]) from comment #10)
> I need to reopen, unfortunately. Neither
> https://crash-stats-django.mozilla.org/report/index/cf1d6f49-ceec-4e10-b342-
> c0b0c2130625 nor
> https://crash-stats.mozilla.com/report/index/cf1d6f49-ceec-4e10-b342-
> c0b0c2130625 show the B2G OS Version in the UI, but
> https://crash-stats-django.mozilla.org/rawdumps/cf1d6f49-ceec-4e10-b342-
> c0b0c2130625.json clearly contains it:
> 
> {
>     "InstallTime": "1371416358",
>     "Version": "24.0a1",
>     "id": "{3c2e2abc-06d4-11e1-ac3b-374f68613e61}",
>     "Android_Hardware": "qcom",
>     "Vendor": "Mozilla",
>     "buildid": "20130616002204",
>     "version": "24.0a1",
>     "CrashTime": "1372171191",
>     "Android_Device": "keon",
>     "Android_CPU_ABI2": "armeabi",
>     "ReleaseChannel": "nightly",
>     "submitted_timestamp": "2013-06-25T14:40:17.478034+00:00",
>     "Android_CPU_ABI": "armeabi-v7a",
>     "URL": "app://camera.gaiamobile.org/manifest.webapp",
>     "timestamp": 1372171217.478063,
>     "Notes": "GL Layers! EGL? EGL+ GL Context? GL Context+ GL Layers+ ",
>     "Android_Manufacturer": "GEEKSPHONE",
>     "Android_Brand": "qcom",
>     "ProcessType": "content",
>     "StartupTime": "1372171183",
>     "BuildID": "20130616002204",
>     "Android_Model": "GP-KEON",
>     "ProductName": "B2G",
>     "legacy_processing": 0,
>     "Android_Version": "15(AOSP)",
>     "Android_Board": "7x27",
>     "B2G_OS_Version": "2.0.0.0-prerelease",
>     "ProductID": "{3c2e2abc-06d4-11e1-ac3b-374f68613e61}"
> }

OK this is an easy fix - I see in the code it's looking for B2G_OS_VERSION and the raw dump above has B2G_OS_Version

Comment 12

[Robert Helmer [:rhelmer]]

r? https://github.com/mozilla/socorro-crashstats/pull/395

Comment 13

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro-crashstats

https://github.com/mozilla/socorro-crashstats/commit/407d942ffeb0b2ec775b34131138df7037f9300f
fixes bug 832351 - use proper case for B2G_OS_Version

https://github.com/mozilla/socorro-crashstats/commit/aec42166a741dbe7fb20d254ab3fca88ff551e60
Merge pull request #395 from rhelmer/bug832351-no-b2g-os-version

fixes bug 832351 - use proper case for B2G_OS_Version

Comment 14

[Stephen Donner [:stephend] Not actively reading bugmail]

This looks good to me on https://crash-stats-django.mozilla.org/report/index/cf1d6f49-ceec-4e10-b342-c0b0c2130625 -- letting Kairo do the official honors.

Comment 15

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Post-fix screenshot

Comment 16

[Robert Kaiser]

Easy to see that bp-ec271e9e-6700-4717-a58b-413be2130117 and bp-cf1d6f49-ceec-4e10-b342-c0b0c2130625 look good now. :)