832368 - Dialog to pick bluetooth file-transfer recipient is really vague. "Choose your option | [Cancel][OK]"

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Bluetooth, defect)

Description

[Daniel Holbert [:dholbert]]

STR:
 1. Have a bluetooth device paired w/ your B2G device (e.g. an android phone)
 2. Open music app, tap the lower-right icon for "albums" view, tap an artist,
    and long-press an audio-file in the final listing.

  --> Bluetooth file-transfer dialog (to choose the target device) appears
 
ACTUAL RESULTS: The dialog says:

>  Choose your option
>  -------------------
>  Nexus 4                  (<---- my paired bluetooth device)
>  -------------------
>
>
>  [ Cancel ][   OK  ]

EXPECTED RESULTS: Something more descriptive/helpful than "Choose your option". :)  Maybe "Select bluetooth device" or "Select bluetooth device that will receive file"

Comment 1

[Daniel Holbert [:dholbert]]

This string is defined here:

https://github.com/mozilla-b2g/gaia/blob/master/apps/bluetooth/locales/bluetooth.en-US.properties#L10

(Note that it's particularly vague w/ the STR I've described above, because there's never any mention of bluetooth or file-transfer on any of the screens I see leading up to this dialog.  That might be partly an issue w/ the Music app.  Still, I think the dialog itself could be more descriptive/helpful here.)

Comment 2

[Lukas Blakk [:lsblakk] use ?needinfo]

No need to track, but flagging UX to take a look and decide where this might get worked on.

Comment 3

[Stephany Wilkes]

We think that the string being requested of UX is already included in this document, on page 3: "Select Bluetooth device..."

https://www.dropbox.com/s/fo28slp3juqyoux/Bluetooth-Sharing_v3.pdf

Please let UX know if anything else is needed here.

Comment 4

[Daniel Holbert [:dholbert]]

Eric, do you know if there are already plans to fix the string per comment 3? ("Select Bluetooth device" instead of "Choose your option".)

(I'm still seeing the same string in this prompt, with the latest unagi beta build, FWIW:
 Build Identifier: 20130510070207
 Update Channel: unagi/1.1.0/beta
)

Comment 5

[Eric Chou [:ericchou] [:echou]]

(In reply to Daniel Holbert [:dholbert] from comment #4)
> Eric, do you know if there are already plans to fix the string per comment
> 3? ("Select Bluetooth device" instead of "Choose your option".)
> 
> (I'm still seeing the same string in this prompt, with the latest unagi beta
> build, FWIW:
>  Build Identifier: 20130510070207
>  Update Channel: unagi/1.1.0/beta
> )

First off, congratulations, Daniel! Finally got an Unagi with Bluetooth working! :P

I haven't seen any related bugs about revising this vague string. We should fix it since current implementation does not follow the UX spec per comment 3. ni? Ian Liu, who implemented Bluetooth file transfer of Gaia.

Comment 6

[[e-mail], [e-mail]]

It's a known issue that we had a discussion with UX team during developing stage. The style of selection dialog is needed to sync with system's select dialog(<select>). But the system one does not have "Cancel" button for an user. And we cannot receive the "Ok" button event until user really changed different option. In fact, the system select dialog is not fit for user story of Bluetooth file transfer. So, we implement a custom select dialog with the same layout for Bluetooth app. In order to sync the title with the system one, we use the string "Choose your option". Then, we can receive "Cancel"/"Ok" event exactly.

Since system select dialog is updated with new bb, the tile has been changed to "Select". It is different with bluetooth paired devices dialog. For the issue, I think we could have a discussion to make it more clearly again.

Casey,
Shall we need to modify the string "Choose your option"?
* Sync with system select dialog --> "Select"
* Use specific string for bluetooth file transfer --> "Select Bluetooth Device"
* Any other suggestion..

Thanks.

Comment 7

[Daniel Holbert [:dholbert]]

(FWIW, I'm strongly in favor of using some language that mentions Bluetooth, because at least from the Music app, the user will trigger this dialog simply by long-pressing a song-title.  If the dialog just says "Select", then it's really unclear what's going on.)

Comment 8

[Daniel Holbert [:dholbert]]

[aside: arguably Comment 7 could be interpeted as a UI bug in the Music app, rather than a bug in the bluetooth-share-target picker.  If that ends up being the interpretation (and the dialog ends up not making it clear that a bluetooth share is about to take place), then we should spin off a bug on making the Music app itself clearer about what's going on.]

Comment 9

[Casey Yee]

I thought we had decided to put the share button in the now-playing screen instead of the difficult to find press-and-hold interaction?    

In any case, I agree with Daniel, we should definitely have "Bluetooth" in there somewhere so that the user understands what they are being asked to choose.

"Select Bluetooth Device" would be my vote.

Comment 10

[[e-mail], [e-mail]]

(In reply to Casey Yee [:cyee] from comment #9)
> I thought we had decided to put the share button in the now-playing screen
> instead of the difficult to find press-and-hold interaction?    
I don't see the share button in the now-playing screen. I still can share the music via press-and-hold. Also cc Dominic for the discussion.
> 
> In any case, I agree with Daniel, we should definitely have "Bluetooth" in
> there somewhere so that the user understands what they are being asked to
> choose.
> 
> "Select Bluetooth Device" would be my vote.
If the sync style is not an issue for UX, let's make the dialog title to be more clear.

Comment 11

[Dominic Kuo [:dkuo]]

The share button in now-playing screen was filed in bug 830040 and tef- so it's not there yet for Music app. If we want it, we need to leo+ it or make it a higher priority.

Comment 12

[[e-mail], [e-mail]]

Nominating leo+ for revising the dialog title. It will easily let the user decision be clear  without bug 830040 landed.

Comment 13

[leo.bugzilla.gecko]

partners need it. please block this.

Comment 14

[[e-mail], [e-mail]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10128

Pointer to Github pull-request

Comment 15

[[e-mail], [e-mail]]

Comment on attachment 756461 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10128

Locale string changed. Revise the title of bluetooth device selector dialog.

-choose-option = Choose your option
+select-bluetooth-device = Select Bluetooth Device

Alive and Stas,
Could you please help to review the pr? Thank you.

Comment 16

[Axel Hecht [:Pike]]

Comment on attachment 756461 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10128

I don't think this needs our input, see https://groups.google.com/forum/#!topic/mozilla.dev.gaia/_T_BTvJ4fJk for details on when we're good folks to ask, and what other options you have.

Comment 17

[Alex Keybl [:akeybl]]

Since this is late-l10n, throwing into the QE3 milestone to ensure we resolve with time to localize.

Comment 18

[[e-mail], [e-mail]]

Since the pr is merged, we can close the issue.

master:    b944fe64f811a243b2756a21a41ce22a863968d0
v1-train:  c507ff65b51194383da65f8927164f078a3e1f79

Comment 19

[John Ford [:jhford] CET/CEST Berlin Time]

1.1hd: c507ff65b51194383da65f8927164f078a3e1f79

Comment 20

[Deepa Subramanian]

The user is able to see "Select bluetooth device" for the selecting Bluetooth file transfer banner.

This issue is fixed as per the expected results on the description.
Leo Build ID: 20130722070207
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/68fb0a2e0114
Gaia: 41d10fb10be6916e6554eb440d9a97130ef23ce0
Platform Version: 18.1

Comment 21

[Walter Chen[:ypwalter][:wachen]]

Gaia:     0f1f1ab0ab31a1df8a780baa048b5e7b2854205d
  B-D     2013-08-15 06:32:03
Gecko:    http://hg.mozilla.org/releases/mozilla-b2g18/rev/692d3414bb12
BuildID   20130815041201
Version   18.0