talosError should follow modern Exception practices

RESOLVED FIXED

Status

RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: k0scist, Assigned: bitgeeky)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][mentor=jmaher][lang=python])

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

6 years ago
http://hg.mozilla.org/build/talos/file/d34468dcc1f8/talos/utils.py#l99

the __init__ and __str__ functions of talosError are pretty
pointless.  Exception does this, essentially, automatically:

>>> class talosError(Exception):
...     """what talosError should look like"""
... 
>>> raise talosError("foo")
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
__main__.talosError: foo
>>> try:
...     raise talosError("bar")
... except talosError, e:
...     print str(e)
... 
bar
>>> from talos.utils import talosError
>>> raise talosError("foo")
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
talos.utils.talosError: 'foo'
>>> try:
...     raise talosError("bar")
... except talosError, e:
...     print str(e)
... 
'bar'

The only difference is that since we `repr(self.msg)` we get some
extra quotes.  We should get rid of the __init__ and __str__ functions
and add a docstring.

The hard part isn't changing the code.  The hard part is finding and
changing the places we refer to talosError.msg (which really isn't
*that* hard).
(In reply to Jeff Hammel [:jhammel] from comment #0)
> http://hg.mozilla.org/build/talos/file/d34468dcc1f8/talos/utils.py#l99
> 
> the __init__ and __str__ functions of talosError are pretty
> pointless.  Exception does this, essentially, automatically:
> 
> >>> class talosError(Exception):
> ...     """what talosError should look like"""
> ... 
> >>> raise talosError("foo")
> Traceback (most recent call last):
>   File "<stdin>", line 1, in <module>
> __main__.talosError: foo
> >>> try:
> ...     raise talosError("bar")
> ... except talosError, e:
> ...     print str(e)
> ... 
> bar
> >>> from talos.utils import talosError
> >>> raise talosError("foo")
> Traceback (most recent call last):
>   File "<stdin>", line 1, in <module>
> talos.utils.talosError: 'foo'
> >>> try:
> ...     raise talosError("bar")
> ... except talosError, e:
> ...     print str(e)
> ... 
> 'bar'
> 
> The only difference is that since we `repr(self.msg)` we get some
> extra quotes.  We should get rid of the __init__ and __str__ functions
> and add a docstring.
> 
> The hard part isn't changing the code.  The hard part is finding and
> changing the places we refer to talosError.msg (which really isn't
> *that* hard).

You could use facebook's codemod to do this (and why not change the name to TalosError while you're at it):

http://wrla.ch/blog/2012/06/mass-code-relicensing-with-facebooks-codemod/
so what should talosError look like?  it would be nice to turn this into an actionable bug, possibly a good first bug !
(Reporter)

Comment 3

5 years ago
Pretty much what will says in comment 1:

class TalosError(Exception):
    """talos-specific error or better docstring"""
Whiteboard: [good first bug][mentor=jmaher][lang=python]
(Assignee)

Comment 4

5 years ago
I am interested in fixing this bug this will be my first bug related to Talos and Hg , please guide how to get started.
Flags: needinfo?(jmaher)
:bitgeeky, great to work with you.

Here is the documentation on talos: https://wiki.mozilla.org/Buildbot/Talos

You can 'hg clone http://hg.mozilla.org/build/talos' to get the source. setup the virtualenv (python INSTALL.py) and try running a test or two. 

Then you can change the code as mentioned in comment #1 to be a real exception/error instead of a bunc hof duplicated and wasted code :)

There are 5 or 6 other really good bugs in Talos that could use some fresh eyes.
Flags: needinfo?(jmaher)
Filed bug 937210 to deal with talosError vs. TalosError, which we should deal with separately.
(Assignee)

Comment 7

5 years ago
:jmaher , may be we were proceeding in wrong direction , as :jhammel mentioned in bug Description talosError.msg has a significant role to play in this bug.
we must change the files like http://hg.mozilla.org/build/talos/file/0987e4cbd219/talos/output.py#l323 
in which e.msg should be replaced with just e , and also regarding talosError and TalosError 
:wlach filed a bug as in comment #6 ,
Now the scope of this bug reduces to remove the extra __init__ and __str__ , add a docstring , change the files where the talosError.msg is used .
Also I think for this bug we can stick to talosError , and later we can also fix the bug 937210 , as a whole since it will just require running command like : find /path/to/start/from/ -type f | xargs perl -pi -e 's/talosError/TalosError/g'  on the talos directory 
as in : http://www.spiration.co.uk/post/522/in-place-replacement-from-command-line 
if I am wrong anywhere please correct me else we can proceed working on it
Thanks :)
Flags: needinfo?(jmaher)
I believe there is one variable named talosError_tb, so if you search and replace, make sure it is only on the class name.

the scope of this looks accurate, I look forward to a patch!
Flags: needinfo?(jmaher)
(Assignee)

Comment 9

5 years ago
Created attachment 830820 [details] [diff] [review]
832422.patch

:jmaher please have a look at the patch and suggest changes if any.
Attachment #830820 - Flags: feedback?(jmaher)
Comment on attachment 830820 [details] [diff] [review]
832422.patch

Review of attachment 830820 [details] [diff] [review]:
-----------------------------------------------------------------

overall this looks great.  I would like to sanity check it before working on landing it.  Have you simulated some error conditions?  Can we add stuff to the tests/ subfolder to test a few conditions here.
Attachment #830820 - Flags: feedback?(jmaher) → feedback+
Comment on attachment 830820 [details] [diff] [review]
832422.patch

Review of attachment 830820 [details] [diff] [review]:
-----------------------------------------------------------------

Some drive-by comments that IMO should also be addressed.

::: talos/results.py
@@ +91,4 @@
>                  _output.output('file://%s' % os.path.join(os.getcwd(), 'results.out'), results)
>              except:
>                  pass
> +            print '\nFAIL: %s' % e.replace('\n', '\nRETURN:')

This won't work, as e is not a string (it can just be cast to one). Try: str(e).replace('\n', '\nRETURN:')

::: talos/utils.py
@@ +70,1 @@
>  

You should make the same modifications to talosCrash, which was added since this bug was filed (but has the same problem we're talking about)
Assignee: nobody → mozpankaj1994
(Assignee)

Comment 12

5 years ago
Created attachment 831856 [details] [diff] [review]
832422v1.patch

:wlach please have a look at the patch and suggest changes if any
Attachment #830820 - Attachment is obsolete: true
Attachment #831856 - Flags: review?(wlachance)
Comment on attachment 831856 [details] [diff] [review]
832422v1.patch

Review of attachment 831856 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good except for some minor problems in test_browser_output.

In normal cases, I would say that you should test your changes before submitting a patch, but it looks like the talos unit tests are currently broken (bug 938664) 
so I can hardly fault you for that. :)

Anyway, everything seems to be working fine after correcting these issues. So please submit a new patch and I'll happily apply.

::: tests/test_browser_output.py
@@ +162,4 @@
>                  import pdb; pdb.set_trace()
> +            self.assertTrue(substr in e)
> +
> +class TestTalosError:

This needs to inherit from unittest.TestCase, otherwise it won't get run. So "class TestTalosError(unittest.TestCase):"

@@ +162,5 @@
>                  import pdb; pdb.set_trace()
> +            self.assertTrue(substr in e)
> +
> +class TestTalosError:
> +    

Please remove this extra line, whitespace we don't want :)

@@ +166,5 @@
> +    
> +    """
> +    test talosError class
> +    """
> +    def test_browser_log_results:

You need to add a self parameter here, so:
 def test_browser_log_results(self):
Attachment #831856 - Flags: review?(wlachance) → review-
(Assignee)

Comment 14

5 years ago
Created attachment 832375 [details] [diff] [review]
832422v2.patch

:wlach thanks for pointing out , made the changes , please have a look again :)
Attachment #831856 - Attachment is obsolete: true
Attachment #832375 - Flags: review?(wlachance)
Comment on attachment 832375 [details] [diff] [review]
832422v2.patch

Great thanks.
Attachment #832375 - Flags: review?(wlachance) → review+
Pushed: https://hg.mozilla.org/build/talos/rev/55fd35f46f08
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.