gfx/thebes/gfxReusableSurfaceWrapper.cpp:29:68: warning: 'visibility' attribute ignored

RESOLVED FIXED in mozilla21

Status

()

RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

(Blocks: 1 bug)

Trunk
mozilla21
x86_64
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
Build warning:
{
gfx/thebes/gfxReusableSurfaceWrapper.cpp: In destructor 'gfxReusableSurfaceWrapper::~gfxReusableSurfaceWrapper()':
gfx/thebes/gfxReusableSurfaceWrapper.cpp:29:68: warning: 'visibility' attribute ignored [-Wattributes]
}

That's for the "NS_IMETHOD Run() { ... }" on a nsRunnable subclass that's defined inside of a function.

If I move the subclass definition out of the function, the warning goes away. Pretty sure that's all we need here.
(Assignee)

Comment 1

6 years ago
Created attachment 704047 [details] [diff] [review]
fix
Attachment #704047 - Flags: review?(bgirard)
(Assignee)

Updated

6 years ago
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
(Assignee)

Comment 2

6 years ago
Created attachment 704049 [details] [diff] [review]
fix [r=BenWa]

(oops, didn't intend to include the makefile tweak. removed that)
Attachment #704047 - Attachment is obsolete: true
Attachment #704047 - Flags: review?(bgirard)
Attachment #704049 - Flags: review?(bgirard)
Comment on attachment 704047 [details] [diff] [review]
fix

FAIL_ON_WARNINGS, nice!
Attachment #704047 - Flags: review+
(Assignee)

Comment 4

6 years ago
This directory isn't quite ready for that (included it accidentally), but almost! (Filing a bug for one more warning, and then after that this directory is warning-free on my machine)
(Assignee)

Comment 5

6 years ago
Comment on attachment 704049 [details] [diff] [review]
fix [r=BenWa]

Carrying forward r+, anyway. :) Thanks!
Attachment #704049 - Attachment description: fix → fix [r=BenWa]
Attachment #704049 - Flags: review?(bgirard) → review+
Awhh to bad. r+ still.
(Assignee)

Updated

6 years ago
Blocks: 832545
https://hg.mozilla.org/mozilla-central/rev/0a5efd0aabfb
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.