Closed Bug 832456 Opened 8 years ago Closed 8 years ago

gfx/thebes/gfxReusableSurfaceWrapper.cpp:29:68: warning: 'visibility' attribute ignored

Categories

(Core :: Graphics, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla21

People

(Reporter: dholbert, Assigned: dholbert)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Build warning:
{
gfx/thebes/gfxReusableSurfaceWrapper.cpp: In destructor 'gfxReusableSurfaceWrapper::~gfxReusableSurfaceWrapper()':
gfx/thebes/gfxReusableSurfaceWrapper.cpp:29:68: warning: 'visibility' attribute ignored [-Wattributes]
}

That's for the "NS_IMETHOD Run() { ... }" on a nsRunnable subclass that's defined inside of a function.

If I move the subclass definition out of the function, the warning goes away. Pretty sure that's all we need here.
Attached patch fix (obsolete) — Splinter Review
Attachment #704047 - Flags: review?(bgirard)
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attached patch fix [r=BenWa]Splinter Review
(oops, didn't intend to include the makefile tweak. removed that)
Attachment #704047 - Attachment is obsolete: true
Attachment #704047 - Flags: review?(bgirard)
Attachment #704049 - Flags: review?(bgirard)
Comment on attachment 704047 [details] [diff] [review]
fix

FAIL_ON_WARNINGS, nice!
Attachment #704047 - Flags: review+
This directory isn't quite ready for that (included it accidentally), but almost! (Filing a bug for one more warning, and then after that this directory is warning-free on my machine)
Comment on attachment 704049 [details] [diff] [review]
fix [r=BenWa]

Carrying forward r+, anyway. :) Thanks!
Attachment #704049 - Attachment description: fix → fix [r=BenWa]
Attachment #704049 - Flags: review?(bgirard) → review+
Awhh to bad. r+ still.
Blocks: 832545
https://hg.mozilla.org/mozilla-central/rev/0a5efd0aabfb
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.