832456 - gfx/thebes/gfxReusableSurfaceWrapper.cpp:29:68: warning: 'visibility' attribute ignored

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Daniel Holbert [:dholbert]]

Build warning:
{
gfx/thebes/gfxReusableSurfaceWrapper.cpp: In destructor 'gfxReusableSurfaceWrapper::~gfxReusableSurfaceWrapper()':
gfx/thebes/gfxReusableSurfaceWrapper.cpp:29:68: warning: 'visibility' attribute ignored [-Wattributes]
}

That's for the "NS_IMETHOD Run() { ... }" on a nsRunnable subclass that's defined inside of a function.

If I move the subclass definition out of the function, the warning goes away. Pretty sure that's all we need here.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: fix [r=BenWa]

(oops, didn't intend to include the makefile tweak. removed that)

Comment 3

[Benoit Girard (:BenWa)]

Comment on attachment 704047 [details] [diff] [review]
fix

FAIL_ON_WARNINGS, nice!

Comment 4

[Daniel Holbert [:dholbert]]

This directory isn't quite ready for that (included it accidentally), but almost! (Filing a bug for one more warning, and then after that this directory is warning-free on my machine)

Comment 5

[Daniel Holbert [:dholbert]]

Comment on attachment 704049 [details] [diff] [review]
fix [r=BenWa]

Carrying forward r+, anyway. :) Thanks!

Comment 6

[Benoit Girard (:BenWa)]

Awhh to bad. r+ still.

Comment 7

[Daniel Holbert [:dholbert]]

Thanks! https://hg.mozilla.org/integration/mozilla-inbound/rev/0a5efd0aabfb

Comment 8

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/0a5efd0aabfb