Closed Bug 832623 Opened 12 years ago Closed 11 years ago

Set -fno-strict-aliasing on gcc <= 4.4 for all platforms

Categories

(Core :: General, defect)

Product:
Core
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla21

People

(Reporter: justin.lebar+bug, Assigned: justin.lebar+bug)

References

Details

Attachments

(1 file)

Patch, v1
2.50 KB, patch
glandium
: review+
Details | Diff | Splinter Review 
In bug 821502, we set -fno-strict-aliasing for gcc <= 4.4 on linux/android.  But of course other platforms build with gcc 4.4 as well.

I put in the linux/android check mostly because I didn't want -fno-strict-aliasing on mac.  But glandium points out (bug 821502 comment 59) that our build now requires clang on mac.  So I think we can just remove the platform check altogether.
Attached patch Patch, v1 — — Splinter Review 

        Attachment #704327 -
        Flags: review?(mh+mozilla)

        Attachment #704327 -
        Flags: review?(mh+mozilla) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/02f222da7df2
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21

    
  
Assignee: nobody → justin.lebar+bug

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: