Closed Bug 832636 Opened 7 years ago Closed 7 years ago
Style Editor .tooltip=CSS Stylesheets Editor shouldn't duplicate 'Stylesheets'
In browser/locales/en-US/chrome/browser/devtools/styleeditor.properties, there is # LOCALIZATION NOTE (ToolboxStyleEditor.tooltip): # This string is displayed in the tooltip of the tab when the debugger is # displayed inside the developer tools window. ToolboxStyleEditor.tooltip=CSS Stylesheets Editor CSS is the abbreviation for 'Cascading Style Sheet[s]', so the current text should be altered to something like 'Editor for Stylesheets (CSS)'. Also don't forget to update the entity id/name both in this file and where it gets called.
I have changed tool tip to the requested fix as per the bug report. This is my first go at this, so if ive done anything wrong, sorry in advance. Jason
Comment on attachment 704511 [details] [diff] [review] patch to change tool tip to 'Editor for Stylesheets (CSS)' > # LOCALIZATION NOTE (ToolboxStyleEditor.tooltip): > # This string is displayed in the tooltip of the tab when the debugger is > # displayed inside the developer tools window. >-ToolboxStyleEditor.tooltip=CSS Stylesheets Editor >+ToolboxStyleEditor.tooltip=Editor for Stylesheets (CSS) Rename ToolboxStyleEditor.tooltip to ToolboxStyleEditor.tooltip2 (it's important for localizer to change the value of the string). Thanks!
I have renamed ToolboxStyleEditor.tooltip to ToolboxStyleEditor.tooltip2 as you requested. Cheers, Jason
The problem now is that there's still a reference to ToolboxStyleEditor.tooltip in the wild. Go to http://mxr.mozilla.org/mozilla-central/ (a search engin for our source code), search for ToolboxStyleEditor.tooltip, you'll see that there is another occurrence to update. And don't forget to update the comment too.
OK, So I think I have done what you have asked for, This has been a great learning curve for me. I have checked for references toToolboxStyleEditor.tooltip in the wild and found the two references here: /browser/devtools/framework/ToolDefinitions.jsm line 135 -- tooltip: l10n("ToolboxStyleEditor.tooltip", styleEditorStrings), /browser/locales/en-US/chrome/browser/devtools/styleeditor.properties (View Hg log or Hg annotations) line 82 -- # LOCALIZATION NOTE (ToolboxStyleEditor.tooltip): line 85 -- ToolboxStyleEditor.tooltip=CSS Stylesheets Editor
I hope that this is the correct fix to this bug now.
Comment on attachment 706295 [details] [diff] [review] Patch to change tool tip to 'Editor for Stylesheets (CSS)' Works well. Can I ask you to just rename "Editor for Stylesheets (CSS)" to "Stylesheet Editor (CSS)"? Once this is done, I will land this patch.
Attachment #706295 - Flags: review?(paul) → review+
As for comment 7 it seems that your patch works well, only another minimal change is required before landing. Are you still working on this? Do you need help?
There's been no reply from the previous contributor, so I assume they're no longer interested in working on this bug.
Whiteboard: [good first bug] → [good first bug][fixed-in-fx-team]
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [good first bug][fixed-in-fx-team] → [good first bug]
Target Milestone: --- → Firefox 27
You need to log in before you can comment on or make changes to this bug.