832638 - Unable to record videos with Nexus S

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[:gerard-majax]

When switching to video recording mode, the camera preview freezes. With Gecko built in debug mode, one can see the following in logcat:

I/PRLog   (  772): 25643216[44776940]: already_AddRefed<mozilla::GonkRecorderProfile> mozilla::GonkRecorderProfileManager::Get(const char*) const:234 : aProfileName='cif'
I/PRLog   (  772): 25643216[44776940]: Recorder profile 'cif' is not supported

Changing profile in Camera app to 480p, the recording fails (with an error message about being unable to save video file) but preview works:
diff --git a/apps/camera/js/camera.js b/apps/camera/js/camera.js
index ff6b090..6bc4b9a 100644
--- a/apps/camera/js/camera.js
+++ b/apps/camera/js/camera.js
@@ -67,10 +67,10 @@ var Camera = {
   },
 
   _previewConfigVideo: {
-    profile: 'cif',
+    profile: '480p',
     rotation: 0,
-    width: 352,
-    height: 288
+    width: 480,
+    height: 800
   },
 
   _shutterKey: 'camera.shutter.enabled',

Looking at the files, we can see that an MPEG4 video has been created:
----rwxr-x system   sdcard_rw   810040 2013-01-19 17:47 VID_0025.3gp
----rwxr-x system   sdcard_rw   810040 2013-01-19 17:47 VID_0026.3gp
----rwxr-x system   sdcard_rw   810040 2013-01-19 17:51 VID_0027.3gp
----rwxr-x system   sdcard_rw   810040 2013-01-19 17:52 VID_0028.3gp

Which seems to be invalid:
$ ffprobe VID_0025.3gp 
avprobe version 0.8.4-6:0.8.4-0ubuntu0.12.10.1, Copyright (c) 2007-2012 the Libav developers
  built on Nov  6 2012 16:51:11 with gcc 4.7.2
[mov,mp4,m4a,3gp,3g2,mj2 @ 0x23a0ba0] moov atom not found
VID_0025.3gp: Invalid data found when processing input

Comment 1

[:gerard-majax]

grepping on adb logcat shows this error which could be interested and related:
E/OMXCodec(  400): [OMX.SEC.AVC.Encoder] ERROR(0x80001000, 0)

Comment 2

[:gerard-majax]

That last error was triggered from encoder, in device/samsung/crespo/sec_mm/sec_omx/sec_codecs/video/mfc_c110/dec/src/SsbSipMfcDecAPI.c, more precisely, it's due to open(/dev/s3c-mfc) failing. Changing permissions to 777, I managed to record a video successfully on Nexus S.

Comment 3

[:gerard-majax]

Attachment: First successful video recording on Nexus S

Proof of video recording success.

Comment 4

[:gerard-majax]

Stock permissions are:
# ls -al /dev/s3c-mfc                                           
crw-rw---- media    media     10, 252 2013-01-19 18:21 s3c-mfc

Comment 5

[:gerard-majax]

Changing permissions to system:camera is enough to get video recording working:

root@android:/ # ls -nal /dev/s3c-jpg                                          
crw-rw---- 1000     1006      10, 254 2013-01-19 18:21 s3c-jpg
root@android:/ # ls -nal /dev/s3c-mfc                                          
crw-rw---- 1013     1013      10, 252 2013-01-19 18:21 s3c-mfc
root@android:/ # chown 1000.1006 /dev/s3c-mfc                                  
root@android:/ # ls -nal /dev/s3c-mfc                                          
crw-rw---- 1000     1006      10, 252 2013-01-19 18:21 s3c-mfc

Comment 6

[:gerard-majax]

Attachment: Patch setting correct permissions for /dev/s3c-mfc file

Comment 7

[:gerard-majax]

Attachment: Set video recording profile in Camera app for Nexus S (480p)

Comment 8

[:gerard-majax]

Pull request for device/samsung/crespo fixes at https://github.com/mozilla-b2g/android-device-crespo/pull/5

Comment 9

[:gerard-majax]

Comment on attachment 704240 [details] [diff] [review]
Patch setting correct permissions for /dev/s3c-mfc file

This as been merged.

Comment 10

[Diego Marcos [:dmarcos]]

Bugs cleanup. This has been merged but the bug remains open.