Closed Bug 832863 Opened 8 years ago Closed 8 years ago

needinfo doesn't work if user confirmation is required

Categories

(bugzilla.mozilla.org :: Extensions, defect)

Production
x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: glob, Assigned: glob)

Details

Attachments

(1 file)

needinfo doesn't work if user confirmation of the requestee is required.
Attached patch patch v1Splinter Review
needinfo_done was being set prior to the user confirmation page, so the "set this flag" phase was being skipped.
Attachment #704461 - Flags: review?(dkl)
Comment on attachment 704461 [details] [diff] [review]
patch v1

Review of attachment 704461 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl
Attachment #704461 - Flags: review?(dkl) → review+
Committing to: bzr+ssh://bjones%40mozilla.com@bzr.mozilla.org/bmo/4.0/
modified extensions/Needinfo/Extension.pm
Committed revision 8447.

Committing to: bzr+ssh://bjones%40mozilla.com@bzr.mozilla.org/bmo/4.2/
modified extensions/Needinfo/Extension.pm
Committed revision 8511.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Component: Extensions: Needinfo → Extensions
You need to log in before you can comment on or make changes to this bug.