needinfo doesn't work if user confirmation is required

RESOLVED FIXED

Status

()

bugzilla.mozilla.org
Extensions: Needinfo
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: glob, Assigned: glob)

Tracking

Production
x86
Mac OS X

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
needinfo doesn't work if user confirmation of the requestee is required.
(Assignee)

Comment 1

4 years ago
Created attachment 704461 [details] [diff] [review]
patch v1

needinfo_done was being set prior to the user confirmation page, so the "set this flag" phase was being skipped.
Attachment #704461 - Flags: review?(dkl)
Comment on attachment 704461 [details] [diff] [review]
patch v1

Review of attachment 704461 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl
Attachment #704461 - Flags: review?(dkl) → review+
(Assignee)

Comment 3

4 years ago
Committing to: bzr+ssh://bjones%40mozilla.com@bzr.mozilla.org/bmo/4.0/
modified extensions/Needinfo/Extension.pm
Committed revision 8447.

Committing to: bzr+ssh://bjones%40mozilla.com@bzr.mozilla.org/bmo/4.2/
modified extensions/Needinfo/Extension.pm
Committed revision 8511.
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.