Last Comment Bug 832863 - needinfo doesn't work if user confirmation is required
: needinfo doesn't work if user confirmation is required
Status: RESOLVED FIXED
:
Product: bugzilla.mozilla.org
Classification: Other
Component: Extensions: Needinfo (show other bugs)
: Production
: x86 Mac OS X
: -- normal (vote)
: ---
Assigned To: Byron Jones ‹:glob›
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-01-20 23:32 PST by Byron Jones ‹:glob›
Modified: 2013-01-21 20:28 PST (History)
1 user (show)
See Also:
Due Date:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch v1 (888 bytes, patch)
2013-01-21 00:00 PST, Byron Jones ‹:glob›
dkl: review+
Details | Diff | Review

Description Byron Jones ‹:glob› 2013-01-20 23:32:12 PST
needinfo doesn't work if user confirmation of the requestee is required.
Comment 1 Byron Jones ‹:glob› 2013-01-21 00:00:03 PST
Created attachment 704461 [details] [diff] [review]
patch v1

needinfo_done was being set prior to the user confirmation page, so the "set this flag" phase was being skipped.
Comment 2 David Lawrence [:dkl] 2013-01-21 14:51:58 PST
Comment on attachment 704461 [details] [diff] [review]
patch v1

Review of attachment 704461 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl
Comment 3 Byron Jones ‹:glob› 2013-01-21 20:28:47 PST
Committing to: bzr+ssh://bjones%40mozilla.com@bzr.mozilla.org/bmo/4.0/
modified extensions/Needinfo/Extension.pm
Committed revision 8447.

Committing to: bzr+ssh://bjones%40mozilla.com@bzr.mozilla.org/bmo/4.2/
modified extensions/Needinfo/Extension.pm
Committed revision 8511.

Note You need to log in before you can comment on or make changes to this bug.