832880 - If devtools.chrome.enabled is off, don't respect the browser modeline

Status: RESOLVED FIXED

(DevTools Graveyard :: Scratchpad, defect, P2)

Comment 1

[Anton Kovalyov (:anton)]

Attachment: Respect browser modeline only if devtools.chrome.enabled is true

Updated code and tests. Also replaced hard-coded SCRATCHPAD_CONTEXT_* variables with gScratchpadWindow properties.

Comment 2

[Heather Arthur [:harth]]

Comment on attachment 705122 [details] [diff] [review]
Respect browser modeline only if devtools.chrome.enabled is true

Review of attachment 705122 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/scratchpad/test/browser_scratchpad_bug_644413_modeline.js
@@ +73,5 @@
> +  // the content context.
> +  is(gScratchpad.executionContext, gScratchpadWindow.SCRATCHPAD_CONTEXT_CONTENT);
> +
> +  // Set the pref and try again.
> +  Services.prefs.setBoolPref(DEVTOOLS_CHROME_ENABLED, true);

Make sure to clear this pref before the test finishes:

Services.prefs.clearUserPref(DEVTOOLS_CHROME_ENABLED);

Comment 3

[Dave Camp (:dcamp)]

(In reply to Heather Arthur [:harth] from comment #2)

> Make sure to clear this pref before the test finishes:
> 
> Services.prefs.clearUserPref(DEVTOOLS_CHROME_ENABLED);

You can use registerCleanup() to make sure this is called no matter if the test fails/times out/whatever - see scratchpad/test/head.js for an example of its use.

Comment 4

[Anton Kovalyov (:anton)]

Attachment: Respect browser modeline only if devtools.chrome.enabled is true

Added registerCleanupFunction that clears the pref. Carrying over r+.

Comment 5

[Anton Kovalyov (:anton)]

https://hg.mozilla.org/integration/fx-team/rev/b8d068584ab3

Comment 6

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/mozilla-central/rev/b8d068584ab3