Make test layout/mathml/tests/stretchy-and-large-operators.html work

RESOLVED FIXED in mozilla21

Status

()

Core
MathML
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: fredw, Assigned: darkowlzz)

Tracking

({helpwanted})

Trunk
mozilla21
helpwanted
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mentor=fredw][lang=js][good first bug], URL)

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

5 years ago
layout/mathml/tests/stretchy-and-large-operators.html is an exhaustive test for the stretchy and large operators from our operator dictionary. However is does not work at the moment, because it incorrectly creates MathML elements with the createElement() function. The function createElementNS() (with the MathML namespace) should be used instead.

(See bug 755541 and 832713 comment 3)
(Assignee)

Comment 1

5 years ago
Created attachment 704958 [details] [diff] [review]
Made changes as per the comment
Attachment #704958 - Flags: review?
(Reporter)

Comment 2

5 years ago
Thanks, that look good. I would put the MathML namespace string in a global variable rather than repeating it everywhere, but that's OK.

Be sure to try to conform to Mozilla's style guides: 80-character lines and a space after the commas.
(https://developer.mozilla.org/En/Mozilla_Coding_Style_Guide)

For the commit message, see a model here:
https://developer.mozilla.org/en-US/docs/Developer_Guide/Committing_Rules_and_Responsibilities#Commit_message_restrictions
Assignee: nobody → indiasuny000
(Assignee)

Comment 3

5 years ago
Created attachment 705008 [details] [diff] [review]
Made changes as per the comment

Made some changes.
Created a global variable to supply namespace to all the creation code.
Attachment #704958 - Attachment is obsolete: true
Attachment #704958 - Flags: review?
Attachment #705008 - Flags: review?(fred.wang)
(Assignee)

Updated

5 years ago
Attachment #705008 - Attachment is obsolete: true
Attachment #705008 - Flags: review?(fred.wang)
(Assignee)

Comment 4

5 years ago
Created attachment 705011 [details] [diff] [review]
Made changes as per the comment

Added Bug number in commit message
Attachment #705011 - Flags: review?(fred.wang)
(Assignee)

Updated

5 years ago
Whiteboard: [mentor=fredw][lang=c++][good first bug] → [mentor=fredw][lang=js][good first bug]
(Reporter)

Comment 5

5 years ago
Comment on attachment 705011 [details] [diff] [review]
Made changes as per the comment

That looks good, thanks!
Attachment #705011 - Flags: review?(fred.wang) → review+
(Assignee)

Updated

5 years ago
Attachment #705011 - Flags: checkin?(fred.wang)
(Reporter)

Updated

5 years ago
Keywords: checkin-needed
(Reporter)

Comment 6

5 years ago
Comment on attachment 705011 [details] [diff] [review]
Made changes as per the comment

I don't have commit access. But I put the checkin-needed keyword, so someone will take care of that relatively soon.
Attachment #705011 - Flags: checkin?(fred.wang)
https://hg.mozilla.org/integration/mozilla-inbound/rev/36477d961bf2
Flags: in-testsuite+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/36477d961bf2
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.