832910 - Should disable (dim) the Character Encoding menu when the top-level content docshell says so

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect)

Description

[Henri Sivonen (:hsivonen)]

Steps to reproduce:
 1) Go to settings.
 2) Enable the character encoding menu.
 3) Navigate to a page where the menu should not have an effect, e.g. http://hsivonen.iki.fi/test/moz/never-show-user-supplied-content-as-utf-16.htm
 4) Open the app menu.

Actual results:
The Character Encoding item in the app menu is enabled.

Expected results:
Expected the Character Encoding item in the app menu to be dimmed and unselectable.

Additional info:
The Character Encoding menu should be dimmed if the mayEnableCharacterEncodingMenu property of the top-level content docshell returns false.

Comment 2

[Frank Yan (:fryn)]

Note to future patch writer: You might find https://bugzilla.mozilla.org/attachment.cgi?id=704457&action=diff helpful as an example of how to use mayEnableCharacterEncodingMenu.

Comment 3

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.