gfxFT2FontList.cpp:938:52: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

RESOLVED FIXED in mozilla21

Status

()

defect
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

(Blocks 1 bug)

Trunk
mozilla21
x86_64
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Build warning on Android:
{
../../../gfx/thebes/gfxFT2FontList.cpp: In function 'void ExtractFontsFromJar(nsIFile*)':
../../../gfx/thebes/gfxFT2FontList.cpp:938:52: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
}
https://tbpl.mozilla.org/php/getParsedLog.php?id=18994418&tree=Try
This is in code added in bug 785291, FWIW -- specifically, this line:
 https://hg.mozilla.org/mozilla-central/rev/d7ff5aecff0c#l1.108
Depends on: 785291
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #704653 - Flags: review?(blassey.bugs)
Attachment #704653 - Flags: review?(blassey.bugs) → review+
Landed: https://hg.mozilla.org/integration/mozilla-inbound/rev/bf506b5f5704

(Marked 'a=nonlibxul' because this is in #ifdef ANDROID code, so it's impossible for it to affect the current Windows PGO libxul issues.  (plus it's just changing the type of a single variable))
https://hg.mozilla.org/mozilla-central/rev/bf506b5f5704
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.