833123 - Story - Share content from a web page

Status: VERIFIED FIXED

(Tracking Graveyard :: Metro Operations, defect)

Description

[Asa Dotzler [:asa]]

Attachment: UC-115 Share content from a web page

Comment 1

[Asa Dotzler [:asa]]

We've got this story covered well enough. Moving remaining dependencies to a lower-priority story and resolving.

Comment 2

[Marco Mucci [:MarcoM]]

Hi Asa,you mentioned this story is covered well enough.  Would you like it marked as invalid or do you want it moved to legacy for Juan to test because the feature is already complete?

Comment 3

[Asa Dotzler [:asa]]

Marco, moved to legacy for Juan to test because the feature is already complete.

Comment 4

[juan becerra [:juanb]]

Tested on 2013-02-28 with a nightly build from http://hg.mozilla.org/mozilla-central/rev/c65d59d33aa8

- Reopening because the sharing options with basic content sharing (text) do not match the story: If I select some text in a page, and select the Share charm, I only get the option to email it.

The text selection seems correct and pre-filled in the body of the message, but the story calls for sharing through Facebook as well, or other options in the People section.

I have not been able to select an image or the whole page.

Comment 5

[Brian R. Bondy [:bbondy]]

Again does this behavior math what IE10 does? 
If not then this should be opened.
If so, then the facebook app I guess simply doesn't accept text and html formats which we provide when there is selected text. 

We have no control about what the application picks to share and also no control over which format the application picks out of the ones we provide. 

I think for testing this we should be the same as IE10.

Comment 6

[Marco Mucci [:MarcoM]]

Hi Juan, can you check Brian's last comment and confirm if this should be reopened or not.

Comment 7

[juan becerra [:juanb]]

Text selection has parity with IE, but image selection does not. Image selection works in IE.  This latter part seems to be tracked in a different but/story (bug 800985), but I don't want to close this one unless it is inteneded that the scope of web content sharing is limited to text.

If it is limited to text we can resolve it and verify it.

Asa, could you comment?

Comment 8

[Asa Dotzler [:asa]]

(In reply to juan becerra [:juanb] from comment #7)
> Text selection has parity with IE, but image selection does not. Image
> selection works in IE.  This latter part seems to be tracked in a different
> but/story (bug 800985), but I don't want to close this one unless it is
> inteneded that the scope of web content sharing is limited to text.
> 
> If it is limited to text we can resolve it and verify it.
> 
> Asa, could you comment?

Let's resolve this story and follow up on selected image sharing as a separate bug. Thanks, Juan.

Comment 9

[juan becerra [:juanb]]

Re-verifying. Text selection can be shared and has parity with IE.

Comment 10

[Brian R. Bondy [:bbondy]]

Juan doe this work for you?
Go to a page and select some text + an image, then share to the mail app.
You should see the html selected + the image selected.

That's because we support showing images through HTML but we don't support image only DIB sharing.

Comment 11

[juan becerra [:juanb]]

This works for me.

I can share text and image selections, but in some sites I can also select pictures only and share them. The tricky part is how selection works in some sites - because touch selection can be a little difficult - but it looks like text and image selection are actually working.

I tried selecting plain images, dpreview.com, and when I bring the sharing charm, and choose to share it with the mail application I see the body of the email with the image I selected. With sites like icanhascheezburger.com I would get some other image I had not selected, but after further testing I see that if I am careful to select just one thing, it works as expected.

Comment 12

[Brian R. Bondy [:bbondy]]

Hey Juan, on icanhascheezburger.com I tried selecting 2 images and the text in between and then shared to the Mail app.  The correct 2 images and text are shown.  Could you maybe explain more how to reproduce getting the wrong images? Maybe with a screenshot that shows the selection I need to do to reproduce?

I don't think the CF_DIB sharing bug is related to this issue by the way.

Comment 13

[Kamil Jozwiak [:kjozwiak]]

Re-verfied for it4 testing and everything passes without any issues. Used the following build:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-04-07-03-08-41-mozilla-central/

Also attempted to reproduce Juan issue from comment 11 but it worked for me without any issues. Selected the entire page at icanhascheezburger.com and shared it through  mail without any problems (all the images + text appeared in the body). Also selected 2-3 images + text and that also worked without any problems.

Comment 14

[Samvedana (:Samvedana)]

User Agent: Mozilla/5.0 (Windows NT 6.2; Win64; x64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130808030205
Built from http://hg.mozilla.org/mozilla-central/rev/fd4cf30428b0

WFM
Tested on windows 8 using latest nightly for iteration-11. Followed steps provided in user story and got expected result. Verified using gmail.

Comment 15

[Samvedana (:Samvedana)]

User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130823030204
Built from http://hg.mozilla.org/mozilla-central/rev/fb2318875cd4

WFM
Tested on windows 8 using latest nightly for iteration-11. Followed steps provided in user story and got expected result. Verified using gmail.