Closed Bug 833125 Opened 8 years ago Closed 8 years ago

test_bug_411966.html bug_411966/redirect.js are still using addURI

Categories

(Toolkit :: Places, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla21

People

(Reporter: mak, Assigned: raymondlee)

References

Details

Attachments

(1 file, 1 obsolete file)

these 2 tests are still using AddURI and should be converted to updatePlaces
Blocks: 739218
Attached patch v1 (obsolete) — Splinter Review
Assignee: nobody → raymond
Status: NEW → ASSIGNED
Attachment #704769 - Flags: review?(mak77)
Comment on attachment 704769 [details] [diff] [review]
v1

Review of attachment 704769 [details] [diff] [review]:
-----------------------------------------------------------------

ugh, one day we should rewrite these tests and make them readable.
I assume the tests passes, the changes look correct though the differences with addURI internals are subtle so it's a bit hard to evaluate off-hand.

::: toolkit/components/places/tests/mochitest/bug_411966/redirect.js
@@ +10,5 @@
>  ok(Ci != null, "Access Ci");
>  const Cc = Components.classes;
>  ok(Cc != null, "Access Cc");
> +const Cu = Components.utils
> +ok(Cu != null, "Access Cu");

these ok checks on Components are really coming from the Mesozoic, please remove them.
Attachment #704769 - Flags: review?(mak77) → review+
(In reply to Marco Bonardo [:mak] from comment #2)
> ::: toolkit/components/places/tests/mochitest/bug_411966/redirect.js
> @@ +10,5 @@
> >  ok(Ci != null, "Access Ci");
> >  const Cc = Components.classes;
> >  ok(Cc != null, "Access Cc");
> > +const Cu = Components.utils
> > +ok(Cu != null, "Access Cu");
> 
> these ok checks on Components are really coming from the Mesozoic, please
> remove them.

Removed


Pushed to try and waiting for results
Attachment #704769 - Attachment is obsolete: true
(In reply to Raymond Lee [:raymondlee] from comment #4)
> https://tbpl.mozilla.org/?tree=Try&rev=3659ba3ac4f7

Passed try
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/5c0b05810722
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.