833125 - test_bug_411966.html bug_411966/redirect.js are still using addURI

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Marco Bonardo [:mak]]

these 2 tests are still using AddURI and should be converted to updatePlaces

Comment 1

[Raymond Lee [:raymondlee]]

Attachment: v1

Comment 2

[Marco Bonardo [:mak]]

Comment on attachment 704769 [details] [diff] [review]
v1

Review of attachment 704769 [details] [diff] [review]:
-----------------------------------------------------------------

ugh, one day we should rewrite these tests and make them readable.
I assume the tests passes, the changes look correct though the differences with addURI internals are subtle so it's a bit hard to evaluate off-hand.

::: toolkit/components/places/tests/mochitest/bug_411966/redirect.js
@@ +10,5 @@
>  ok(Ci != null, "Access Ci");
>  const Cc = Components.classes;
>  ok(Cc != null, "Access Cc");
> +const Cu = Components.utils
> +ok(Cu != null, "Access Cu");

these ok checks on Components are really coming from the Mesozoic, please remove them.

Comment 3

[Raymond Lee [:raymondlee]]

Attachment: Patch for check-in

(In reply to Marco Bonardo [:mak] from comment #2)
> ::: toolkit/components/places/tests/mochitest/bug_411966/redirect.js
> @@ +10,5 @@
> >  ok(Ci != null, "Access Ci");
> >  const Cc = Components.classes;
> >  ok(Cc != null, "Access Cc");
> > +const Cu = Components.utils
> > +ok(Cu != null, "Access Cu");
> 
> these ok checks on Components are really coming from the Mesozoic, please
> remove them.

Removed


Pushed to try and waiting for results

Comment 4

[Raymond Lee [:raymondlee]]

https://tbpl.mozilla.org/?tree=Try&rev=3659ba3ac4f7

Comment 5

[Raymond Lee [:raymondlee]]

(In reply to Raymond Lee [:raymondlee] from comment #4)
> https://tbpl.mozilla.org/?tree=Try&rev=3659ba3ac4f7

Passed try

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5c0b05810722

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5c0b05810722