Closed
Bug 833215
Opened 10 years ago
Closed 9 years ago
B2G RIL: Rename getFoo to readFoo in ICC Record
Categories
(Core :: DOM: Device Interfaces, defect)
Tracking
()
RESOLVED
FIXED
mozilla23
People
(Reporter: allstars.chh, Assigned: allstars.chh)
Details
(Whiteboard: [fixed-in-birch])
Attachments
(2 files)
11.46 KB,
patch
|
vicamo
:
review+
|
Details | Diff | Splinter Review |
9.53 KB,
patch
|
vicamo
:
review+
|
Details | Diff | Splinter Review |
For ICC Elementary Files, the operations to read/write are called 'read' and 'update'. For example, READ_RECORD/READ_BINARY, UPDATE_RECORD, UPDATE_BINARY. However current functions to get those EF are prefixed with 'get', for example, getMSISDN, getMBDN, in order to make the naming to conform the specification, we should rename them to readMSISDN, readMBDN... etc. Also I've spotted some different style to decode those parcels in ICC Record Helper, we should make the style consistent.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → allstars.chh
Assignee | ||
Comment 1•9 years ago
|
||
Assignee | ||
Comment 2•9 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Attachment #736622 -
Flags: review?(vyang)
Assignee | ||
Updated•9 years ago
|
Attachment #736623 -
Flags: review?(vyang)
Updated•9 years ago
|
Attachment #736622 -
Flags: review?(vyang) → review+
Comment 3•9 years ago
|
||
Comment on attachment 736623 [details] [diff] [review] Part 2: Use the same style to parse. Review of attachment 736623 [details] [diff] [review]: ----------------------------------------------------------------- Please also check xpcshell tests :)
Attachment #736623 -
Flags: review?(vyang) → review+
Assignee | ||
Comment 4•9 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=35f0be1cef91
Assignee | ||
Comment 5•9 years ago
|
||
http://hg.mozilla.org/projects/birch/rev/e9a1c44d1ca9 http://hg.mozilla.org/projects/birch/rev/4bb7ccc2d743
Whiteboard: [fixed-in-birch]
Comment 6•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e9a1c44d1ca9 https://hg.mozilla.org/mozilla-central/rev/4bb7ccc2d743
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in
before you can comment on or make changes to this bug.
Description
•