833215 - B2G RIL: Rename getFoo to readFoo in ICC Record

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh]]

For ICC Elementary Files, the operations to read/write are called 'read' and 'update'.
For example, READ_RECORD/READ_BINARY, UPDATE_RECORD, UPDATE_BINARY.

However current functions to get those EF are prefixed with 'get', for example, getMSISDN, getMBDN, in order to make the naming to conform the specification, we should rename them to readMSISDN, readMBDN... etc.

Also I've spotted some different style to decode those parcels in ICC Record Helper, we should make the style consistent.

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh]]

Attachment: Part 1: rename getFoo to readFoo in ICCRecordHelper.

Comment 2

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh]]

Attachment: Part 2: Use the same style to parse.

Comment 3

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 736623 [details] [diff] [review]
Part 2: Use the same style to parse.

Review of attachment 736623 [details] [diff] [review]:
-----------------------------------------------------------------

Please also check xpcshell tests :)

Comment 4

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh]]

https://tbpl.mozilla.org/?tree=Try&rev=35f0be1cef91

Comment 5

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh]]

http://hg.mozilla.org/projects/birch/rev/e9a1c44d1ca9
http://hg.mozilla.org/projects/birch/rev/4bb7ccc2d743

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/e9a1c44d1ca9
https://hg.mozilla.org/mozilla-central/rev/4bb7ccc2d743