833232 - [OPEN_] User should be able to make emergency calls in the dialer app, with passcode disabled (617001976498)

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Firefox_Mozilla]

Steps to reproduce:
1, turn on the SIM card's PIN code; 
2, restart the phone, 
3.Observe the interface of the PIN code; 

Expected results:
the interface displays the correct SOS call button; 

Actual results:
The interface of entering your PIN has no SOS callbutton.

Comment 1

[Al Tsai [:atsai]]

We'll need a fix of PIN code keyboard if we want it to be fixed.

Comment 2

[Joe Cheng [:jcheng] (please needinfo)]

this should be blocker. There is no way for the user to dial emergency call when the device is SIM PIN locked and is presented with the SIM PIN unlock UI (this is different from the lockscreen passcode lock where you can still make an emergency call)

Comment 3

[Andrew Overholt [:overholt]]

Joe, can you find an assignee?

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

https://bugzilla.mozilla.org/show_bug.cgi?id=796726 This one?

Comment 5

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Al Tsai [:atsai] from comment #1)
> We'll need a fix of PIN code keyboard if we want it to be fixed.

Customized keyboard. Proposed change should be to extract the keyboard UI from lockscreen to shared folder.
(Or copy paste...)

Comment 6

[Joe Cheng [:jcheng] (please needinfo)]

(In reply to Alive Kuo [:alive] from comment #5)
> (In reply to Al Tsai [:atsai] from comment #1)
> > We'll need a fix of PIN code keyboard if we want it to be fixed.
> 
> Customized keyboard. Proposed change should be to extract the keyboard UI
> from lockscreen to shared folder.
> (Or copy paste...)

+1, the lock screen UI seems to be a good reference but require UX input

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Wait, let's not get a head of ourselves ...

SIM PIN panel is not the problem here since it is cancelable (by pressing "x" on the top left) -- user can always reach the dialer with that. The problem is that dialer doesn't switch to |dialEmergency()| in this network state.

A fix without UI change should do it.

Comment 8

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Checking with Etienne on comment above. Do you agree that is the right fix instead?

Comment 9

[Lukas Blakk [:lsblakk] use ?needinfo]

Marking this affected for status-b2g18 and status-b2g18-v1.0.0 --- please update these flags when the PR is landed to v1-train and v1.0.0

Comment 10

[Etienne Segonzac (:etienne)]

(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) from comment #8)
> Checking with Etienne on comment above. Do you agree that is the right fix
> instead?

Yes!
Especially since we *can* detect this network state ;)
(So we're not having the emergency number detection issue here.)

Comment 11

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Update title while keeping partner tracking number/flags. Please implement comment 7 if you intend to take this bug.

Keeping needinfo? josh as he would might want to verify this.

Comment 12

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: Patch v1

Use mozTelephony.dialEmergency() when the sim card state is 'pinRequired' or 'pukRequired'. Users are able to make emergency calls while they may not realize they can do it without UI changes.

Comment 13

[Etienne Segonzac (:etienne)]

Comment on attachment 708958 [details] [diff] [review]
Patch v1

Review of attachment 708958 [details] [diff] [review]:
-----------------------------------------------------------------

This will probably need rebasing since we removed 
|var conn = window.navigator.mozMobileConnection;| from the global TelephonyHelper scope for performance reason.

r=me, with a |var conn = window.navigator.mozMobileConnection;| added inside the |startDial| function.

Thanks!

Comment 14

[Arthur Chen [:arthurcc][inactive after 6/30]]

Landed on master. https://github.com/mozilla-b2g/gaia/commit/4e5b4b1e696ca210be2168ec27d25eb7b610443b
Landed on v1-train. https://github.com/mozilla-b2g/gaia/commit/00c034963f436de06e517ca93434ef7e885cc5e8
Landed on v1.0.0. https://github.com/mozilla-b2g/gaia/commit/da39f0b896ef86aaa7dccba6ef6941edde745f37

Thanks Etienne!

Comment 15

[Josh Carpenter [:jcarpenter]]

Getting to this belatedly. I have not used SIM lock so I cannot comment reliably on the solution here, but the description sounds reasonable, and it sounds like it was achieved without changing the current UI?

Comment 16

[Mila Davydova]

Verified as fixed. User is able to make emergency calls in dialer app with passcode disabled.
Unagi device, (nightly) build 20130215070202
Dec 5th Kernel
Gecko  http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/a9e4f8912607
Gaia   21ba59d933c66024cb351c2379315301d5352e0c