Closed Bug 833297 Opened 7 years ago Closed 7 years ago

ensure graphite shaper does not overwrite cluster information

Categories

(Core :: Graphics: Text, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla21

People

(Reporter: jfkthame, Assigned: jfkthame)

References

Details

Attachments

(2 files, 1 obsolete file)

Discovered through word/line-breaking reftests with a font configuration where fallback chooses a graphite font for combining marks that are not supported in the main font. When deciding whether to use a 'simple' glyph record, the shaper needs to check that the non-cluster-start flag has not been set at the current position in the shaped text; if it's a cluster continuation, then we must not overwrite it with a simple glyph.
Blocks: 700023
r+ with the inclusion of a reftest for this case
Attachment #704836 - Flags: review?(jdaggett) → review+
Reftest for the issue here; without the patch, it will incorrectly line-break before the combining marks (when graphite shaping is enabled).
And now with HTTP(..) in the manifest, so that it will actually load the intended fonts (oops!)
Attachment #705307 - Attachment is obsolete: true
Attachment #705308 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/011d0b0befdc
https://hg.mozilla.org/mozilla-central/rev/363a34802aef
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.