833327 - slideshow continues to rotate when video thumbnail has focus

Status: RESOLVED FIXED

(www.mozilla.org :: Bedrock, defect)

Description

[Isac Lagerblad (:icaaq)]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:21.0) Gecko/20130122 Firefox/21.0
Build ID: 20130122030956

Steps to reproduce:

1. Press Cmd+N to open a new browser window, then type https://www-demo1.allizom.org/en-US/ in the address bar and press Enter
2. Use your keyboard and tab your way to the play video image in the first slide
3. wait


Actual results:

Slide number two is shown in the slideshow


Expected results:

slideshow should be paused as it does on the other slides when it has focus

Comment 1

[Michael Gauthier [:gauthierm]]

https://github.com/mozilla/bedrock/pull/696

Comment 2

[Isac Lagerblad (:icaaq)]

Seems to work :)

I talked to sgarrity on IRC and suggested a more general way to do it in mozilla-pager.js

Have a look at http://www.nczonline.net/blog/2013/02/12/making-an-accessible-dialog-box/ under "Trapping focus". You should be able to look for focus events and see if it comes from a focusable element inside of the pager.

Comment 3

[Michael Gauthier [:gauthierm]]

See https://github.com/mozilla/bedrock/pull/699 for a more general solution using focusin/focusout in mozilla-pager.js

Comment 4

[Isac Lagerblad (:icaaq)]

looks great!

Comment 5

[raymond [:retornam] (inactive)]

fixed www.allizom.org