833336 - Needinfo tries to match the needinfo user even when you decided you didn't need info

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Extensions, defect)

Description

[Benjamin Smedberg]

If you started to request needinfo from a specific person and then discover that the person doesn't have a bugzilla account (or you just can't find them), the needinfo extension still won't let you change the bug.

Steps to reproduce:
* Comment in a bug
* In the bug, choose needinfo: "other" and start typing "bamboo"
* bamboo is not unique and the person you wanted is not present. So instead clear the needinfo checkbox
* Hit submit

Expected:
* The bug comment will be submitted, but no needinfo will be applied

Actual:
* Bugzilla prompts me to choose somebody who matches "bamboo".

Comment 1

[:glob ✱]

Attachment: patch v1

only do user matching when the needinfo checkbox is checked.

Comment 2

[David Lawrence [:dkl]]

Comment on attachment 704874 [details] [diff] [review]
patch v1

Review of attachment 704874 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me and fixes the issue. r=dkl

Comment 3

[:glob ✱]

Committing to: bzr+ssh://[e-mail]/bmo/4.0/
modified extensions/Needinfo/Extension.pm
Committed revision 8449.

Committing to: bzr+ssh://[e-mail]/bmo/4.2/
modified extensions/Needinfo/Extension.pm
Committed revision 8513.