Needinfo tries to match the needinfo user even when you decided you didn't need info

RESOLVED FIXED

Status

()

bugzilla.mozilla.org
Extensions: Needinfo
--
minor
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: bsmedberg, Assigned: glob)

Tracking

Production
x86_64
Linux

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
If you started to request needinfo from a specific person and then discover that the person doesn't have a bugzilla account (or you just can't find them), the needinfo extension still won't let you change the bug.

Steps to reproduce:
* Comment in a bug
* In the bug, choose needinfo: "other" and start typing "bamboo"
* bamboo is not unique and the person you wanted is not present. So instead clear the needinfo checkbox
* Hit submit

Expected:
* The bug comment will be submitted, but no needinfo will be applied

Actual:
* Bugzilla prompts me to choose somebody who matches "bamboo".
(Assignee)

Updated

5 years ago
Assignee: nobody → glob
Status: NEW → ASSIGNED
(Assignee)

Comment 1

5 years ago
Created attachment 704874 [details] [diff] [review]
patch v1

only do user matching when the needinfo checkbox is checked.
Attachment #704874 - Flags: review?(dkl)
Comment on attachment 704874 [details] [diff] [review]
patch v1

Review of attachment 704874 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me and fixes the issue. r=dkl
Attachment #704874 - Flags: review?(dkl) → review+
(Assignee)

Comment 3

5 years ago
Committing to: bzr+ssh://bjones%40mozilla.com@bzr.mozilla.org/bmo/4.0/
modified extensions/Needinfo/Extension.pm
Committed revision 8449.

Committing to: bzr+ssh://bjones%40mozilla.com@bzr.mozilla.org/bmo/4.2/
modified extensions/Needinfo/Extension.pm
Committed revision 8513.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.