Closed
Bug 833336
Opened 11 years ago
Closed 11 years ago
Needinfo tries to match the needinfo user even when you decided you didn't need info
Categories
(bugzilla.mozilla.org :: Extensions, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: benjamin, Assigned: glob)
Details
Attachments
(1 file)
|
1.35 KB,
patch
|
dkl
:
review+
|
Details | Diff | Splinter Review |
If you started to request needinfo from a specific person and then discover that the person doesn't have a bugzilla account (or you just can't find them), the needinfo extension still won't let you change the bug. Steps to reproduce: * Comment in a bug * In the bug, choose needinfo: "other" and start typing "bamboo" * bamboo is not unique and the person you wanted is not present. So instead clear the needinfo checkbox * Hit submit Expected: * The bug comment will be submitted, but no needinfo will be applied Actual: * Bugzilla prompts me to choose somebody who matches "bamboo".
only do user matching when the needinfo checkbox is checked.
Attachment #704874 -
Flags: review?(dkl)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 704874 [details] [diff] [review] patch v1 Review of attachment 704874 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me and fixes the issue. r=dkl
Attachment #704874 -
Flags: review?(dkl) → review+
Committing to: bzr+ssh://bjones%40mozilla.com@bzr.mozilla.org/bmo/4.0/ modified extensions/Needinfo/Extension.pm Committed revision 8449. Committing to: bzr+ssh://bjones%40mozilla.com@bzr.mozilla.org/bmo/4.2/ modified extensions/Needinfo/Extension.pm Committed revision 8513.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Updated•5 years ago
|
Component: Extensions: Needinfo → Extensions
You need to log in
before you can comment on or make changes to this bug.
Description
•