Closed
Bug 833427
Opened 13 years ago
Closed 13 years ago
Remove the homescreen search widget
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox19+ verified, firefox20 verified, firefox21 verified)
VERIFIED
FIXED
Firefox 21
People
(Reporter: mfinkle, Assigned: sriram)
Details
Attachments
(2 files, 1 obsolete file)
|
1.50 KB,
patch
|
mfinkle
:
review+
akeybl
:
approval-mozilla-aurora+
akeybl
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
|
29.63 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
Product wants to remove the homescreen search widget added in bug 708707.
|
||
Updated•13 years ago
|
tracking-firefox19:
--- → ?
|
Assignee | |
Comment 1•13 years ago
|
||
This removes the receiver in AndroidManifest.xml, thereby Android doesn't know about a widget in the apk. (Minimal change).
Attachment #705007 -
Flags: review?(mark.finkle)
|
Reporter | |
Comment 2•13 years ago
|
||
Comment on attachment 705007 [details] [diff] [review]
Option 1: Hide
This is a good start. We can uplift this more safely.
Attachment #705007 -
Flags: review?(mark.finkle) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
This removes all the code required for widgets.
Attachment #705012 -
Flags: review?(mark.finkle)
|
|
Reporter | |
Comment 4•13 years ago
|
||
Comment on attachment 705012 [details] [diff] [review]
Option 2: Remove
Can we remove "widget_icon.png" too?
|
|
Assignee | |
Comment 5•13 years ago
|
||
I had missed removing the widget_icon.png in branding folders. This patch removes them all.
Attachment #705012 -
Attachment is obsolete: true
Attachment #705012 -
Flags: review?(mark.finkle)
Attachment #705018 -
Flags: review?(mark.finkle)
|
|
Reporter | |
Comment 6•13 years ago
|
||
Comment on attachment 705018 [details] [diff] [review]
Option 2: Remove
This is the patch I'd like to keep for nightly
Attachment #705018 -
Flags: review?(mark.finkle) → review+
|
|
Assignee | |
Comment 7•13 years ago
|
||
Pushed the easy part: https://hg.mozilla.org/integration/mozilla-inbound/rev/335f68150ae0
|
||
Comment 8•13 years ago
|
||
Comment on attachment 705007 [details] [diff] [review]
Option 1: Hide
This is low risk and what we want to do for FF19/20. Preapproving for uplift, assuming green builds/tests.
Attachment #705007 -
Flags: approval-mozilla-beta+
Attachment #705007 -
Flags: approval-mozilla-aurora+
|
|
||
Updated•13 years ago
|
|
||
Comment 9•13 years ago
|
||
status-firefox19:
--- → fixed
|
|
||
Comment 10•13 years ago
|
||
status-firefox20:
--- → fixed
|
|
||
Updated•13 years ago
|
|
||
Comment 11•13 years ago
|
||
Assignee: nobody → sriram
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 21
|
|
Reporter | |
Comment 12•13 years ago
|
||
Sriram - It's time to push Option #2 into Nightly.
|
||
Comment 13•13 years ago
|
||
Widgets are hidden for Firefox Mobile 19 beta 3 and Aurora 20.0a2 2013-01-23 on Nightly 21.0a1 2013-01-23 I can still find the widget so the 2nd fix has not yet made it to nightly. Verifying the fix for Beta and Aurora.
Tested on:
Samsung Galaxy Tab (Android 3.1)
status-firefox21:
--- → affected
|
||
Comment 14•13 years ago
|
||
Ah man ... I patched that forward!
|
|
||
Comment 15•13 years ago
|
||
The widget is no longer available for Nightly 21.0a1 2013-01-30 on the Acer Iconia A500 (Android 3.2)
Status: RESOLVED → VERIFIED
|
|
Assignee | |
Comment 16•12 years ago
|
||
Landed the second patch: https://hg.mozilla.org/integration/mozilla-inbound/rev/ca9f4c6458c4 (after a few months! :( )
|
||
Comment 17•12 years ago
|
||
|
||
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•