833447 - nsDOMBlobBuilder.cpp:284:8: warning: variable ‘nativeEOL’ set but not used [-Wunused-but-set-variable]

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Daniel Holbert [:dholbert]]

Build warning in GCC 4.7:
{
nsDOMBlobBuilder.cpp:284:8: warning: variable ‘nativeEOL’ set but not used [-Wunused-but-set-variable]
}

for this chunk of code:
268 nsresult
269 nsDOMMultipartFile::InitFile(JSContext* aCx,
270                              uint32_t aArgc,
271                              jsval* aArgv)
272 {
[...]
284   bool nativeEOL = false;
285   if (aArgc > 1) {
286     FilePropertyBag d;
287     if (!d.Init(aCx, nullptr, aArgv[1])) {
288       return NS_ERROR_TYPE_ERR;
289     }
290     mName = d.mName;
291     mContentType = d.mType;
292     nativeEOL = d.mEndings == EndingTypesValues::Native;
293   }
https://mxr.mozilla.org/mozilla-central/source/content/base/src/nsDOMBlobBuilder.cpp#284

So -- native EOL is set (at line 284 and 292), but it never gets used.  Is it supposed to be used?

This warning is in code added in bug 811615:
https://hg.mozilla.org/mozilla-central/rev/1af75383fd2e#l2.78

(It looks like this might just be copypaste cruft from a similar chunk in nsDOMMultipartFile::InitBlob(), which also has nativeEOL and actually uses it.)

Comment 1

[Andrea Marchesini [:baku]]

Attachment: patch

Comment 2

[Andrea Marchesini [:baku]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4b6d8e1061da

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4b6d8e1061da