833505 - nsGIOProtocolHandler.cpp:583:888: warning: deleting object of polymorphic class type ‘nsGIOInputStream’ which has non-virtual destructor might cause undefined behaviour [-Wdelete-non-virtual-dtor]

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Daniel Holbert [:dholbert]]

Noticed some -Wdelete-non-virtual-dtor warnings in GIO/Gnome code today:
{
extensions/gio/nsGIOProtocolHandler.cpp:583:888: warning: deleting object of polymorphic class type ‘nsGIOInputStream’ which has non-virtual destructor might cause undefined behaviour [-Wdelete-non-virtual-dtor]

extensions/gio/nsGIOProtocolHandler.cpp:900:2687: warning: deleting object of polymorphic class type ‘nsGIOProtocolHandler’ which has non-virtual destructor might cause undefined behaviour [-Wdelete-non-virtual-dtor]

toolkit/system/gnome/nsGSettingsService.cpp:136:2708: warning: deleting object of polymorphic class type 'nsGSettingsCollection' which has non-virtual destructor might cause undefined behaviour [-Wdelete-non-virtual-dtor]

toolkit/system/gnome/nsGSettingsService.cpp:322:2681: warning: deleting object of polymorphic class type 'nsGSettingsService' which has non-virtual destructor might cause undefined behaviour [-Wdelete-non-virtual-dtor]
}

These can all be fixed by MOZ_FINAL annotations.  I'll push that with blanket-r=ehsan, per bug 829975 comment 3.

Comment 1

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a7ba9c337287

Comment 2

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a7ba9c337287