833524 - remove all trace of .mozpass.cfg and .android from linux builders

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Aki Sasaki (not active)]

Now that bug 705807 landed, we need to clean up:

a) puppet patch to remove all .mozpass.cfg and .android/ from ~cltbld on linux builders
** write, review, land, roll out, wait to run everywhere, back out
b) remove all references to .mozpass.cfg and .android/ from docs
** new image docs first
** slave loaner docs after (a) is done.

Comment 1

[Aki Sasaki (not active)]

https://wiki.mozilla.org/index.php?title=ReleaseEngineering/How_To/Set_Up_a_Freshly_Imaged_Slave&diff=503899&oldid=498141

Comment 2

[Aki Sasaki (not active)]

TODO, once we remove .mozpass.cfg and .android/ everywhere:
https://intranet.mozilla.org/RelEngWiki/index.php/How_To/Clean_A_Slave_For_Shipment_Externally

Comment 3

[Aki Sasaki (not active)]

Attachment: clean puppet part 1

_ review
_ land
_ update puppet servers
_ remove these files from puppet servers if applicable
_ write new patch (should still remove debug.keystore)
_ review
_ land (after all linux builders are updated)
_ update puppet servers
_ update above TODO wiki page
_ close bug

Comment 4

[Rail Aliiev [:rail]]

Comment on attachment 705075 [details] [diff] [review]
clean puppet part 1

Review of attachment 705075 [details] [diff] [review]:
-----------------------------------------------------------------

Could you also prepare a patch for puppetagain (http://hg.mozilla.org/build/puppet/) - we have those files on mock slaves as well.

::: os/centos.pp
@@ +76,4 @@
>  
>                  "/home/cltbld/.android/android.keystore":
> +                    ensure => absent,
> +                    force => true;

you can remove this entry all together because the previous one should remove the whole directory.

Comment 5

[Aki Sasaki (not active)]

(In reply to Rail Aliiev [:rail] from comment #4)
> Could you also prepare a patch for puppetagain
> (http://hg.mozilla.org/build/puppet/) - we have those files on mock slaves
> as well.

There doesn't seem to be any existing file that references these; creating a new directory structure / file in build/puppet is far beyond my weak puppet skills.

Comment 6

[Aki Sasaki (not active)]

X puppet-manifests patch
X  review
_  land  <-- WE ARE HERE (might wait til morning)
_  update puppet servers
_ puppetagain patch <-- someone else?
_  review
_  land
_  update puppetagain masters
_ remove these files from puppet servers if applicable
_ write new patch (should still remove debug.keystore)
_ review
_ land (after all linux builders are updated)
_ update puppet servers
_ update above TODO wiki page
_ close bug

Comment 7

[Justin Wood (:Callek)]

Attachment: [puppetAgain] v1

Since aki wasn't comfortable writing this.

Comment 8

[Justin Wood (:Callek)]

Attachment: [puppetAgain] v1.1

I was too quick on the draw, this uses the correct var

Comment 9

[Rail Aliiev [:rail]]

Comment on attachment 705103 [details] [diff] [review]
[puppetAgain] v1.1

lgtm

Comment 10

[Aki Sasaki (not active)]

Attachment: puppet-manifests with fixes

Comment 11

[Aki Sasaki (not active)]

Comment on attachment 705104 [details] [diff] [review]
puppet-manifests with fixes

Carrying forward review.
http://hg.mozilla.org/build/puppet-manifests/rev/ed85a33b23a3

Comment 12

[Aki Sasaki (not active)]

(In reply to Aki Sasaki [:aki] from comment #6)
> X puppet-manifests patch
> X  review
> X  land
> X  update puppet servers
> X puppetagain patch (Callek)
> X  review
> _  land  <-- WE ARE HERE
> _ remove these files from puppet servers if applicable
> _ write new patch (should still remove debug.keystore)
> _ review
> _ land (after all linux builders are updated)
> _ update puppet servers
> _ update above TODO wiki page
> _ close bug

Comment 13

[Aki Sasaki (not active)]

Comment on attachment 705103 [details] [diff] [review]
[puppetAgain] v1.1

http://hg.mozilla.org/build/puppet/rev/f3c2cc8dc47d

Comment 14

[Aki Sasaki (not active)]

X puppet-manifests patch
X  review
X  land
X  update puppet servers
X puppetagain patch (Callek)
X  review
X  land
X remove these files from puppet servers if applicable
_ verify
_ write new patch (should still remove debug.keystore)
_ review
_ land (after all linux builders are updated)
_ update puppet servers
_ update above TODO wiki page
_ rm root@scl3-production-puppet:.android and .mozpass.cfg
_ close bug

We have a backup of .mozpass.cfg and .android in root@scl3-production-puppet:.

Comment 15

[Aki Sasaki (not active)]

Attachment: remove mozpass.py from tools

Comment 16

[Aki Sasaki (not active)]

Comment on attachment 705127 [details] [diff] [review]
remove mozpass.py from tools

http://hg.mozilla.org/build/tools/rev/2ae3f3775686

Comment 17

[Aki Sasaki (not active)]

#!/bin/sh

for i in `cat foo`; do
    /bin/echo -n "$i - "
    ping -c 1 -o -t 5 $i 2>&1 >/dev/null
    if [ $? -eq 0 ] ; then
        output=`ssh -o "StrictHostKeyChecking no" -o ConnectTimeout=10 cltbld@$i ls -a 2>/dev/null`
        if [ $? -eq 0 ] ; then
            echo $output | egrep -q '(mozpass|android)'
            if [ $? -ne 0 ] ; then
                echo
            else
                echo 'FOUND!'
            fi
        fi
    else
        echo
    fi
done

Comment 18

[Aki Sasaki (not active)]

Attachment: output

From above script.
I cleaned up all FOUND! hosts manually.

Comment 19

[Aki Sasaki (not active)]

Attachment: remove from puppet-manifests

For puppetagain, we can just back out http://hg.mozilla.org/build/puppet/rev/f3c2cc8dc47d .

Comment 20

[Aki Sasaki (not active)]

X puppet-manifests patch
X  review
X  land
X  update puppet servers
X puppetagain patch (Callek)
X  review
X  land
X remove these files from puppet servers if applicable
X verify -- done, depending on how paranoid you are
X write new puppet-manifests patch (should still remove debug.keystore)
_ review  <-- WE ARE HERE
_ land puppet-manifests patch, backout puppetagain patch
_ update puppet servers
_ update https://intranet.mozilla.org/RelEngWiki/index.php/How_To/Clean_A_Slave_For_Shipment_Externally
_ rm root@scl3-production-puppet:.android and .mozpass.cfg
_ close bug

Comment 21

[Rail Aliiev [:rail]]

Comment on attachment 706118 [details] [diff] [review]
remove from puppet-manifests

Review of attachment 706118 [details] [diff] [review]:
-----------------------------------------------------------------

::: os/centos.pp
@@ +73,3 @@
>                  "/home/cltbld/.android/debug.keystore":
>                      ensure => absent,
>                      force => true;

Why do you need this entry?

Comment 22

[Aki Sasaki (not active)]

(In reply to Rail Aliiev [:rail] from comment #21)
> ::: os/centos.pp
> @@ +73,3 @@
> >                  "/home/cltbld/.android/debug.keystore":
> >                      ensure => absent,
> >                      force => true;
> 
> Why do you need this entry?

"_ write new patch (should still remove debug.keystore)"

~/.android/debug.keystore is automatically created if the apk isn't signed by anything else.  This creates a signed dev build, which can't be installed anywhere else.

This isn't actually a critical bug until debug.keystore gets to be a year old (when it's auto-created, it's created to expire in 1 year).  Then anything that uses the debug.keystore to sign anything will burn.

I thought auto-removing it would be a safer option than to hit this issue again in the future.

Comment 23

[Rail Aliiev [:rail]]

Comment on attachment 706118 [details] [diff] [review]
remove from puppet-manifests

Sheep it! :)

Comment 24

[Aki Sasaki (not active)]

Comment on attachment 706118 [details] [diff] [review]
remove from puppet-manifests

http://hg.mozilla.org/build/puppet-manifests/rev/caf4b681e337

Comment 25

[Aki Sasaki (not active)]

X puppet-manifests patch
X  review
X  land
X  update puppet servers
X puppetagain patch (Callek)
X  review
X  land
X remove these files from puppet servers if applicable
X verify -- done, depending on how paranoid you are
X write new puppet-manifests patch (should still remove debug.keystore)
X review
X land puppet-manifests patch
X update puppet servers
_ backout puppetagain patch <-- WE ARE HERE
_ update https://intranet.mozilla.org/RelEngWiki/index.php/How_To/Clean_A_Slave_For_Shipment_Externally
_ rm root@scl3-production-puppet:.android and .mozpass.cfg
_ close bug

Callek thinks we should wait to remove the puppetagain patch, since we could have AWS slaves that aren't up or reachable via ssh that still have these files.

Comment 26

[Aki Sasaki (not active)]

Comment on attachment 705103 [details] [diff] [review]
[puppetAgain] v1.1

Backed out, 
http://hg.mozilla.org/build/puppet/rev/3c15d8fdd761

[14:11]	<nthomas>	what's the cut off time ?
[14:13]	<aki>	http://hg.mozilla.org/build/puppet/rev/f3c2cc8dc47d
[14:13]	<aki>	Jan 22 3pmish PST ?
[14:13]	<aki>	14:43 is when it landed
[14:13]	<nthomas>	all fine then, the oldest launch times are Jan 29

Comment 27

[Aki Sasaki (not active)]

https://intranet.mozilla.org/RelEngWiki/index.php?title=How_To/Clean_A_Slave_For_Shipment_Externally&diff=1533&oldid=1515

X puppet-manifests patch
X  review
X  land
X  update puppet servers
X puppetagain patch (Callek)
X  review
X  land
X remove these files from puppet servers if applicable
X verify -- done, depending on how paranoid you are
X write new puppet-manifests patch (should still remove debug.keystore)
X review
X land puppet-manifests patch
X update puppet servers
X backout puppetagain patch
X update https://intranet.mozilla.org/RelEngWiki/index.php/How_To/Clean_A_Slave_For_Shipment_Externally
X rm root@scl3-production-puppet:.android and .mozpass.cfg
X close bug <-- WE ARE HERE