833546 - Tabs menu forgets current selection of tabs view and opens automatically upon rotation

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

STR:

i) Open a private tab, and switch to it
ii) Open the menu, and rotate the device to landscape
iii) Close the menu
iv) Rotate device back to portrait

--
Nightly (01/22)
Samsung Galaxy Nexus (Android 4.2)

Comment 1

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

The problem is that, on rotation the tabs-tray is re-inflated. This causes the item changed listener to be called -- when the last visited tabs was "Private" (as the inflated one has "Tabs" as selected entry).

To avoid this, the selection listener will show the tabs tray only if the tabs-tray was visible before rotation.

Comment 2

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ab76caba70f3

Comment 3

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/b868c9ca7a0a - robocop was unhappy in testNewTab

Comment 4

[Sriram Ramasubramanian [:sriram]]

This patch didn't cause the issue, hence pushing it in again:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cce24522fbf3

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/cce24522fbf3

Comment 6

[Andreea Pod]

Verified fixed on:
-build:  Firefox for Android 21.0a1 (2013-02-15)
-device: Samsung Galaxy Nexus
-OS: Android 4.2.1