833595 - [mediadb] ignore change events for hidden files

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[David Flanagan [:djf]]

MediaDB ignores files and directories whose names begin with "." when scanning.  But it does not correctly ignore device storage change events for those same files.

When the Camera app records a video, it generates then deletes a dot file like this, which causes the following warning in logcat:

Content JS WARN at app://gallery.gaiamobile.org/shared/js/mediadb.js:1274 in anonymous: MediaDB: Unknown file in insertRecord: DCIM/100MZLLA/.VID_0004.3gp

This particular warning is benign, so we don't need to fix this in the 1.0.x timeline, but we should track it and get the patch I'm about to fix landed soonish.

Comment 1

[David Flanagan [:djf]]

Attachment: link to patch on github

Dale,

This is a minor patch to mediadb related to the Camera's use of a dot file. The review should be simple, but is not urgent, since I don't know when we'll be able to land this.

Comment 2

[David Flanagan [:djf]]

I've attached a patch and have nominated this as tracking-b2g18 so we don't forget to land it.

Comment 3

[Dale Harvey (:daleharvey)]

Comment on attachment 705131 [details]
link to patch on github

Sorry I was certain I had already r+'d this

Comment 4

[David Flanagan [:djf]]

merged into master:
https://github.com/mozilla-b2g/gaia/commit/b29c27f68bbc19ea4f3fbfc03db059c41ccfb2d2

Comment 5

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted commit b29c27f68bbc19ea4f3fbfc03db059c41ccfb2d2 as:
v1-train: 31db4d6fe361bd094decf8529a508fbe9950e39b

Comment 6

[Dominic Kuo [:dkuo]]

Please see
https://bugzilla.mozilla.org/show_bug.cgi?id=861930#c6 and
https://bugzilla.mozilla.org/show_bug.cgi?id=861930#c7
for nominating this to tef+, thanks.

Comment 7

[John Ford [:jhford] CET/CEST Berlin Time]

v1.0.1: 44b7bab93ce4e6c712a8659366c817641845d76c

Comment 8

[Cody Roesch [:croesch]]

Unable to test here. Marking as QARegressExclude.