833660 - wrong icon of notification when take a screenshot after received a file from bluetooth

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Attachment: a notification with bluetooth icon

STR:
1. receive a file from bluetooth
2. take a screenshot by power + home

expected:
a screenshot notification without icon

actually: 
a screenshot notification with bluetooth icon!

Comment 1

[Deepa Subramanian]

There is "Dialer icon" on the notification bar while taking a screen shot. This issue reproduces on unagi device Build ID: 20130124070201.

Comment 2

[Deepa Subramanian]

Attachment: wrong icon after screenshot

Comment 3

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Attachment: pull request

pull request: https://github.com/mozilla-b2g/gaia/pull/7896

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 708517 [details]
pull request

r=me, thank you!

Comment 5

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Merged.
https://github.com/mozilla-b2g/gaia/commit/461cddde0934b17a861331c5490590cc83641d0d

Comment 6

[Askeing Yen[:askeing][:fyen]]

Unagi
Gaia:     1ab1a866549e7b8644a9f51ef76d984a82ea8612
Gecko:    http://hg.mozilla.org/mozilla-central/rev/d7553251cf43
BuildID   20130701031306
Version   25.0a1

Verified on m-c build.

Comment 7

[Antonio Manuel Amaya Calvo (:amac)]

Why wasn't this uplifted to 1.1? IIRC this was fixed even before the 1.1 branch was created... and the bug is reproducible there also. It'll be more important also once IM apps are added (if they show for example the image from the user sending the IM on the notification, then all the rest of the iconless notificatons will carry that image, which is... pretty noticeable).

Comment 8

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Actually I have no idea for this, but seems it's too late for landing to v1.1.

Comment 9

[Beatriz Rodríguez [:brg]]

I am sorry to say that we need a patch for this issue in v1-train.
This issue will impact a large number of users and can increase the number of calls to the support department.

Please fix this in v1-train. Nominating accordingly.

Comment 10

[Peter Dolanjski [:pdol]]

(In reply to Beatriz Rodríguez [:brg] from comment #9)
> I am sorry to say that we need a patch for this issue in v1-train.
> This issue will impact a large number of users and can increase the number
> of calls to the support department.
> 
> Please fix this in v1-train. Nominating accordingly.

Beatriz, are you sure that this would be the source of support calls?  Yes, it is the wrong icon, but the notification message is pretty clear.  I am just concerned that it is very late to be taking more patches.

Comment 11

[Peter Dolanjski [:pdol]]

Yuren, could you clarify if this bug affects EVERY notification for which no icon is included (ie. it displays the previous notification's icon) or is it just the scenario in which a screenshot is taken?

Comment 12

[Jason Smith [:jsmith]]

(In reply to Peter Dolanjski [:pdol] from comment #11)
> Yuren, could you clarify if this bug affects EVERY notification for which no
> icon is included (ie. it displays the previous notification's icon) or is it
> just the scenario in which a screenshot is taken?

I think it does - the past icon affects the new one more generally. I've seen this doing mozNotification API testing a while back with the SMS icon being present on notifications I created without an icon when I received a SMS before.

Comment 13

[Jason Smith [:jsmith]]

(In reply to Peter Dolanjski [:pdol] from comment #10)
> (In reply to Beatriz Rodríguez [:brg] from comment #9)
> > I am sorry to say that we need a patch for this issue in v1-train.
> > This issue will impact a large number of users and can increase the number
> > of calls to the support department.
> > 
> > Please fix this in v1-train. Nominating accordingly.
> 
> Beatriz, are you sure that this would be the source of support calls?  Yes,
> it is the wrong icon, but the notification message is pretty clear.  I am
> just concerned that it is very late to be taking more patches.

This issue is already present on 1.01. I don't think SUMO reports have shown evidence of this our support feedback, which leads me to believe this isn't a top support compliant. I can double check with the SUMO team to be sure however.

Michelle - Have we seen negative support feedback around wrong icons in notifications? If so, how much negative feedback have we received?

Comment 14

[Daniel Coloma:dcoloma]

I am not totally sure the feedback for 1.0.1 is very relevant here as in 1.1 Simple Push is going to be available and we expect IM apps to proliferate. With users using IM extensively we expect then number of notifications to increase accordingly and hence the occurrences of this issue in real world to do so.

Comment 15

[Peter Dolanjski [:pdol]]

After speaking with Beatriz offline, it was indeed verified that this affects all instances where a notification is shown with no icon.
The use case of concern that Daniel describes is where an app uses push (which will ramp up notification frequency) and non-generic icons (eg. a person's face) which will display for notifications not attributed to the displayed person - a very bad UX.

Comment 16

[Jason Smith [:jsmith]]

(In reply to Daniel Coloma:dcoloma from comment #14)
> I am not totally sure the feedback for 1.0.1 is very relevant here as in 1.1
> Simple Push is going to be available and we expect IM apps to proliferate.
> With users using IM extensively we expect then number of notifications to
> increase accordingly and hence the occurrences of this issue in real world
> to do so.

Fair enough.

Comment 17

[John Ford [:jhford] CET/CEST Berlin Time]

This bug was partially uplifted.

Uplifted 461cddde0934b17a861331c5490590cc83641d0d to:
v1.2 already had this commit

Commit 461cddde0934b17a861331c5490590cc83641d0d didn't uplift to branch v1-train

Comment 18

[John Ford [:jhford] CET/CEST Berlin Time]

(In reply to John Ford [:jhford] -- please use 'needinfo?' instead of a CC from comment #17)
> This bug was partially uplifted.
> 
> Uplifted 461cddde0934b17a861331c5490590cc83641d0d to:
> v1.2 already had this commit
> 
> Commit 461cddde0934b17a861331c5490590cc83641d0d didn't uplift to branch
> v1-train

This slightly confusing comment means that this didn't uplift to v1.1, but was already a part of v1.2.  Please resolve the merge conflicts on v1-train (v1.1) manually

Comment 19

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

merged to v1-train.
https://github.com/mozilla-b2g/gaia/commit/6231c3540d33d4cc1e8b914dbfe119a561a9911c

Comment 20

[Tim Guan-tin Chien [:timdream] (please needinfo)]

v1.1.0hd: 6f5752d9af94cf05e02aab36a25b12e960a6544e