833885 - transitions in class .devtools-no-search-result are ineffective

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Girish Sharma [:Optimizer]]

bug 650804 introduced a class devtools-no-search-result for searchbox with no search output for the given input.

devtools-no-search-result has transitions on box-shadow, border-color and background-image which are all ineffective as the transitions at 

http://mxr.mozilla.org/mozilla-central/source/browser/themes/winstripe/devtools/inspector.css#221

take precedence, also introduced in the same bug.

As background-image is already no transition-able, best option might be to remove the transitions from class devtools-no-search-result completely to maintain consistency.

Comment 1

[Paul Rouget [:paul]]

> okay, but apparently background-image cannot be transitioned. So having only a border transitioned along with a sudden changing background does not seem well. Removing the whole transition from .devtools-no-search-result seems to be a better option.

Works for me.

Comment 2

[Girish Sharma [:Optimizer]]

Attachment: patch

removed the transition styles from all the three stripes.

Comment 3

[Girish Sharma [:Optimizer]]

Attachment: patch 2

Also noticed in this [1] screenshot posted by paul once that the search icon is misaligned by 1 px (the same was happening on Mac) so fixing that too.

[1] http://i.imgur.com/n5hSeif.png

Comment 4

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/integration/fx-team/rev/feb13fd4d2d5

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/feb13fd4d2d5