Closed Bug 833908 Opened 10 years ago Closed 10 years ago

B2G RIL: Expose SPN variables in nsIICCRecords

Categories

(Firefox OS Graveyard :: General, defect)

Product:
Firefox OS Graveyard
Component:
General
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:tef+, firefox19 wontfix, firefox20 wontfix, firefox21 fixed, b2g18 fixed, b2g18-v1.0.0 fixed, b2g18-v1.0.1 fixed)

Status:
RESOLVED FIXED
Milestone:
B2G C4 (2jan on)
Project Flags:
blocking-b2g tef+
Tracking Flags:
Tracking Status
firefox19 --- wontfix
firefox20 --- wontfix
firefox21 --- fixed
b2g18 --- fixed
b2g18-v1.0.0 --- fixed
b2g18-v1.0.1 --- fixed

People

(Reporter: pgravel, Assigned: vicamo)

References

Details

(Whiteboard: QARegressExclude)

Attachments

(1 file)

explicitly export spn related attributes in nsIICCRecords
1.73 KB, patch
allstars.chh
: review+
pgravel
: feedback+
Details | Diff | Splinter Review 
Similar issue as Bug 828330

SPN related variables are not exposed by nsIICCRecords in nsIRadioInterfaceLayer.idl, which is needed by commercial RIL to display spn information.

The following variables need to be copied from nsIDOMMozMobileICCInfo in nsIDOMMobileConnection.idl to achieve parity

 readonly attribute DOMString spn;
 readonly attribute boolean isDisplayNetworkNameRequired;
 readonly attribute boolean isDisplaySpnRequired;
Group: qualcomm-confidential
I think it will be easier this way. :)
Status: NEW → RESOLVED
blocking-b2g: tef? → ---
Closed: 10 years ago
Resolution: --- → DUPLICATE
As requested in bug 830164 comment #19, let's have a quick fix like what's done in bug 828330.
Status: RESOLVED → REOPENED
blocking-b2g: --- → tef?
Resolution: DUPLICATE → ---
blocking-b2g: tef? → tef+
Assignee: nobody → vyang

        Attachment #705756 -
        Flags: review?(allstars.chh)

        Attachment #705756 -
        Flags: feedback?(pgravel)

        Attachment #705756 -
        Flags: review?(allstars.chh) → review+

    
    

    
  
Looks good to me.

    
  

        Attachment #705756 -
        Flags: feedback?(pgravel) → feedback+

    
    

    
  
I'll help to push this change.

    
    

    
  
(In reply to Yoshi Huang[:yoshi][:allstars.chh] from comment #5)
> I'll help to push this change.

Thank you :)

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/3226c8ac08f7
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED

          status-firefox19:
          affected → wontfix

          status-firefox20:
          affected → wontfix
Target Milestone: --- → B2G C4 (2jan on)

    
    

    
  
Does not make sense to create a regression issue.
Flags: in-moztrap-

    
  
Whiteboard: QARegressExclude

    
    

    
  
Cannot verify, need steps to blackbox test this issue.

          You need to log in
          before you can comment on or make changes to this bug.