mozRTCIceCandidate constructor looks for 'sdbMid' rather than 'sdpMid' in its argument

VERIFIED FIXED in mozilla21

Status

()

Core
WebRTC: Networking
P2
normal
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: Andrew Miller, Assigned: Andrew Miller)

Tracking

Trunk
mozilla21
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [webrtc][blocking-webrtc+])

Attachments

(2 attachments)

(Assignee)

Description

5 years ago
Created attachment 705511 [details]
Test case which creates a RTCIceCandidate and fetches the sdpMid property.

According to http://www.w3.org/TR/webrtc/#idl-def-RTCIceCandidate, the RTCIceCandidate constructor expects a property called 'sdpMid'. However, the code (in dom/media/PeerConnection.js IceCandidate.prototype.constructor) typos that as sdbMid.

Test case attached:
  Expected results with testcase: "y" shows up in the alert.
  Actual result with testcase: "z" shows up in the alert.
(Assignee)

Comment 1

5 years ago
Created attachment 705517 [details] [diff] [review]
Simple patch to fix the misspelling - no attempt at bug compatibility
Assignee: nobody → ak.miller
Attachment #705517 - Flags: review?(rjesup)

Updated

5 years ago
Attachment #705517 - Flags: review?(rjesup) → review+

Updated

5 years ago
Priority: -- → P2
Whiteboard: [webrtc][blocking-webrtc+]
(Assignee)

Updated

5 years ago
Attachment #705517 - Flags: checkin?
(Assignee)

Comment 2

5 years ago
I don't have try-server access or access to all the platforms, so have only tested this on Linux x86-64 so this may need to be tested on the try server first.
Keywords: checkin-needed
Attachment #705517 - Flags: checkin?
https://hg.mozilla.org/integration/mozilla-inbound/rev/6eea9913acdd
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/6eea9913acdd
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21

Updated

5 years ago
Keywords: verifyme
Verified on 1/30 build. Probably worth getting a quick error test here.
Status: RESOLVED → VERIFIED
Flags: in-testsuite?
Keywords: verifyme
This is a fix of a spelling error in the code. I can't imagine there is something we could test here.
Flags: in-testsuite? → in-testsuite-
You need to log in before you can comment on or make changes to this bug.