Closed
Bug 833968
Opened 12 years ago
Closed 12 years ago
B2G emulator crashtests are marked with T-FAIL even when they were successful
Categories
(Release Engineering :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ahal, Assigned: ahal)
References
Details
(Whiteboard: [mozharness])
Attachments
(1 file)
1.30 KB,
patch
|
mozilla
:
review+
|
Details | Diff | Splinter Review |
Assignee | ||
Updated•12 years ago
|
Component: Reftest → Release Engineering: Automation (General)
Product: Testing → mozilla.org
QA Contact: catlee
Version: unspecified → other
Assignee | ||
Updated•12 years ago
|
Whiteboard: [mozharness]
Assignee | ||
Comment 1•12 years ago
|
||
This fixes the problem, but makes me wonder.. Should crashtests be a separate test suite at all? Or should the buildbot-configs just pass in the crashtest manifest to the reftest suite?
Attachment #705888 -
Flags: review?(aki)
Comment 2•12 years ago
|
||
Comment on attachment 705888 [details] [diff] [review]
Patch 1.0 - add crashtest entry to tinderboxprintre
> This fixes the problem, but makes me wonder.. Should crashtests be a separate test suite at all? Or should the buildbot-configs just pass in the crashtest manifest to the reftest suite?
Possibly.
We've treated crashtests as separate historically, but if refactoring saves us enough it might be worth it.
Attachment #705888 -
Flags: review?(aki) → review+
Assignee | ||
Comment 3•12 years ago
|
||
I'll leave it as is, refactoring doesn't really save anything. I just didn't know how it was normally done.
https://hg.mozilla.org/build/mozharness/rev/7b46580edbc7
For some reason that link isn't showing me the diff, but it's there when I click "diff" on the file. Bug in hgweb?
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment 4•12 years ago
|
||
(In reply to Andrew Halberstadt [:ahal] from comment #3)
> https://hg.mozilla.org/build/mozharness/rev/7b46580edbc7
>
> For some reason that link isn't showing me the diff, but it's there when I
> click "diff" on the file. Bug in hgweb?
wfm?
Assignee | ||
Comment 5•12 years ago
|
||
Weird, ctrl-shift-r fixed it. /me shrugs
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
Updated•7 years ago
|
Component: General Automation → General
You need to log in
before you can comment on or make changes to this bug.
Description
•