834047 - Install a packaged app, check for updates, run the app, apply updates, restart the phone - app gets stuck in "ready to apply download" state, which makes it impossible to ever get the app update

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Jason Smith [:jsmith]]

Build: B2G 18 1/23/2013
Device: Unagi

Steps:

1. Install a packaged app
2. Update it on the server
3. Check for updates (manual or automatic)
4. Start running the app
5. Apply the app update
6. After the update finishes, restart the phone
7. Try running the app

Expected:

I would expect that the app update should have been applied after the phone was restarted, as the update is downloaded, but only just needs to be applied.

Actual:

The app that launches is the old app. Trying to check for updates will find no updates. So at this point, you will never be able to get updates for the app ever again.

Additional Notes:

  "{d28d3f10-b3e6-495f-a042-3ee21eaf68b9}": {
    "name": "Test WebAPI Permissions",
    "csp": "",
    "installOrigin": "http://mozqa.com",
    "origin": "app://{d28d3f10-b3e6-495f-a042-3ee21eaf68b9}",
    "receipts": [],
    "installTime": 1358983570508,
    "manifestURL": "http://mozqa.com/webapi-permissions-tests/simple_packaged_up
date/simple_packaged_update.manifest",
    "appStatus": 1,
    "removable": true,
    "id": "{d28d3f10-b3e6-495f-a042-3ee21eaf68b9}",
    "localId": 1023,
    "basePath": "/data/local/webapps",
    "progress": 17075,
    "installState": "updating",
    "downloadAvailable": false,
    "downloading": false,
    "readyToApplyDownload": true,
    "downloadSize": 17000,
    "lastUpdateCheck": 1358983570508,
    "updateTime": 1358983725037,
    "etag": "\"2584d1-176-4d3fcf1cff640\"",
    "packageEtag": "\"2584d3-42b3-4d2ed3b406280\"",
    "manifestHash": "bc355a37fcf84e8c69f2be4b7abd4fdb",
    "packageHash": "4f31ee6a92261b0a82e0fc2eaba47afd",
    "installerAppId": 1011,
    "installerIsBrowser": true,
    "lastCheckedUpdate": 1358983888739,
    "retryingDownload": false
  }

Comment 1

[Jason Smith [:jsmith]]

Nom - this risks potential permanent dataloss with a non-removal preloaded app to never get updates again.

Comment 2

[[:fabrice] Fabrice Desré]

Are you sure we don't get updates again if a new version is pushed?

Comment 3

[Jason Smith [:jsmith]]

(In reply to Fabrice Desré [:fabrice] from comment #2)
> Are you sure we don't get updates again if a new version is pushed?

Haven't tried that. I'll investigate.

Comment 4

[[:fabrice] Fabrice Desré]

Interesting.
At step 5, the app record is as expected (slightly different from Jason's because I'm running a build with a few patches, see https://tbpl.mozilla.org/?tree=Try&rev=1f047c64e5ce) :
"{33658e8a-edb6-4dcd-9cca-d9ccbf296469}": {
    "name": "Packaged app",
    "csp": "",
    "installOrigin": "http://people.mozilla.org",
    "origin": "app://{33658e8a-edb6-4dcd-9cca-d9ccbf296469}",
    "receipts": [],
    "installTime": 1359009704427,
    "manifestURL": "http://people.mozilla.org/~fdesre/updates/manifest.webapp",
    "appStatus": 1,
    "removable": true,
    "id": "{33658e8a-edb6-4dcd-9cca-d9ccbf296469}",
    "localId": 1031,
    "basePath": "/data/local/webapps",
    "progress": 43401520,
    "installState": "updating",
    "downloadAvailable": false,
    "downloading": false,
    "readyToApplyDownload": true,
    "downloadSize": 10000,
    "lastUpdateCheck": 1359009704427,
    "updateTime": 1359009893128,
    "etag": "\"162\"",
    "packageEtag": "\"2cb3\"",
    "manifestHash": "42aaa08f5fabad441f46e3bcbdd5dee2",
    "packageHash": "f24cdb06ccdbf3c1d3e27f46c377cfad",
    "staged": {
      "manifestHash": "6a96192fd35816ccbe4d7298a6a689e1",
      "etag": "\"163\"",
      "packageEtag": "\"2964130\"",
      "packageHash": "64f41c88055a6b7dd395534cc09073b8",
      "appStatus": 1
    },
    "installerAppId": 1013,
    "installerIsBrowser": true,
    "lastCheckedUpdate": 1359009807557,
    "retryingDownload": false
  }

and in /data/local/tmp/webapps/{33658e8a-edb6-4dcd-9cca-d9ccbf296469} we find the staged package and manifest:
-rw-r----- root     root     43401520 2013-01-23 22:44 application.zip
-rw-r----- root     root          316 2013-01-23 22:44 manifest.webapp

When restarting we're in the same state, and gaia doesn't offer to apply the update (it should!). If I check for updates, the gecko update checker find one update (I/Gecko   (  108): UpdatePrompt: appsUpdated: 1 apps to update) but gaia doesn't offer anything either.

So it looks like the issue is on the gaia side.

Comment 5

[Julien Wajsberg [:julienw]]

I'm busy with testing the Webapps update flow, I think Etienne or Michal can take this bug instead.

Comment 6

[Michał Budzyński (:michalbe)]

Attachment: patch

Comment 7

[Julien Wajsberg [:julienw]]

Comment on attachment 706009 [details]
patch

please also add "a=tef+" in the end of your commit log (in addition to r=julienw :) )

Comment 8

[Michał Budzyński (:michalbe)]

https://github.com/mozilla-b2g/gaia/commit/5fc5a34983d5df4193c2ef4fc59e4511b52b1872

Comment 9

[Jason Smith [:jsmith]]

Umm...is this really status-b2g18 fixed? Did this land on v1.0.0? I don't see it there. Julien? Can you clarify?

Comment 10

[Julien Wajsberg [:julienw]]

It's not, that's why I added "affected" instead of keeping it void to make it clear that it needs uplifting (by vivien) :)

maybe we need another way ?

Comment 11

[Jason Smith [:jsmith]]

Verified on 1/25 build.