Closed Bug 834113 Opened 11 years ago Closed 10 years ago

[OPEN_][Bluetooth] we can not view the Bluetooth address in settings.(617001980873)

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(b2g18+)

RESOLVED FIXED
Tracking Status
b2g18 + ---

People

(Reporter: Firefox_Mozilla, Assigned: bruhuang)

References

Details

(Whiteboard: [MZ][good first bug][mentor=ehung][mentor-lang=zh][device-required])

Attachments

(2 files)

Steps to reproduce:
1. go into the settings;
2. try to view the Bluetooth address;

Expected results:
we can check the Bluetooth address;

Actual results:
the device does not have the menu to check or view Bluetooth address;
We don't have it in v1 spec.
Flags: needinfo?(jcheng)
add tracking flag for next version consideration
Flags: needinfo?(jcheng)
OS: Windows XP → Gonk (Firefox OS)
Hardware: x86 → ARM
Group: partner-confidential → mozilla-corporation-confidential
Group: mozilla-corporation-confidential
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee: nobody → khu
It sounds like a feature request to me.
Whiteboard: [MZ]
Assignee: khu → echou
blocking-b2g: --- → koi?
Privileged Gaia apps can get Bluetooth address of local device via |defaultAdapter.address|. This should be a Gaia/Settings feature. Redirect to Evelyn, the owner of Settings app.
Assignee: echou → ehung
Component: Gaia::Bluetooth File Transfer → Gaia::Settings
It's easy to add this item in Settings, but we need UX input to define a correct place.
Flags: needinfo?(firefoxos-ux-bugzilla)
Reassigning to Eric (while Rob is out and we're short on help) for input on placement in Settings.
Flags: needinfo?(firefoxos-ux-bugzilla)
Flags: needinfo?(epang)
my suggestion would be to add the bluetooth address within 'More Information' in settings above the 'reset device' button.

Also, i'm not sure if this is being taken care of in another bug, but can we increase the space between the label and detail info? Right now it's looking very tight.  I've mocked it up to have a 16px spacing from baseline to baseline. Thanks!
Flags: needinfo?(epang)
Push to v1.3 as v1.2 have already feature frozen.

Joe?
blocking-b2g: koi? → 1.3?
Flags: needinfo?(jcheng)
will discuss in triage sessions
Flags: needinfo?(jcheng)
Triage: push to backlog as this is not a critical feature.
blocking-b2g: 1.3? → ---
Depends on: 908549
Whiteboard: [MZ] → [MZ][good first bug][mentor=ehung]
Blocks: 908549
No longer depends on: 908549
Whiteboard: [MZ][good first bug][mentor=ehung] → [MZ][good first bug][mentor=ehung][mentor-lang=zh]
Is this a good-first-bug and requiring device to verified? If so, I want to tag it in the whiteboard.
Flags: needinfo?(timdream)
(In reply to Greg Weng [:snowmantw] from comment #11)
> Is this a good-first-bug and requiring device to verified? If so, I want to
> tag it in the whiteboard.

Yes, Bluetooth API is only available on actual device, not on B2G/Desktop nor emulator AFIAK.
Flags: needinfo?(timdream)
Whiteboard: [MZ][good first bug][mentor=ehung][mentor-lang=zh] → [MZ][good first bug][mentor=ehung][mentor-lang=zh][device-required]
Add Bluetooth address to settings based on UX proposal in comment 7.
Hi Evelyn, tried to take a stab at this in comment 13, is it alright for me to take this bug off your hands?  Thanks.
Flags: needinfo?(ehung)
(In reply to bruce <bruhuang@gmail.com> from comment #14)
> Hi Evelyn, tried to take a stab at this in comment 13, is it alright for me
> to take this bug off your hands?  Thanks.

Sure, I'm reviewing your patch in comment 13. Please do flag a reviewer on your next patch to catch your reviewers' attention. Thanks!
Assignee: ehung → bruhuang
Flags: needinfo?(ehung)
Attachment #8351550 - Flags: review?(ehung)
Comment on attachment 8351550 [details] [review]
Add Bluetooth address to settings.

I think the patch is okay to me because it follows the same logic of Mac Address. However, we will refactor some of these code because we want sub-panels are independent, i.e. every panel should be self-contained to update its information, never reply on root panel (connectivity.js or settings.js in this patch) to update a sub-panel's entries.
Anyway, I think we can land this patch and leave refactor work as a follow-up.

@Arthur, what do you think?
Attachment #8351550 - Flags: review?(ehung) → review+
Flags: needinfo?(arthur.chen)
Let's land the patch. We will refactor it along with the mac address part.
Flags: needinfo?(arthur.chen)
merged into gaia-master: https://github.com/mozilla-b2g/gaia/commit/9cfc5da54cc69a8d700f1e5267759878be88fd69
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: