834118 - B2G CDMA: Add CDMA network type in the function of setting preferred network type.

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Ken Chang[:kenkai]]

We only support WCDMA and GSM network types in the function of setting preferred network type. For CDMA, we have to add CDMA network type in that function.

Comment 1

[Ken Chang[:kenkai]]

Attachment: Add CDMA and EVDO network type

Comment 2

[Hsin-Yi Tsai (she/her) | away [:hsinyi]]

Comment on attachment 705712 [details] [diff] [review]
Add CDMA and EVDO network type

Review of attachment 705712 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the comments addressed :)

::: dom/system/gonk/ril_consts.js
@@ +340,5 @@
>  this.GECKO_PREFERRED_NETWORK_TYPE_WCDMA_ONLY = "wcdma";
> +this.GECKO_PREFERRED_NETWORK_TYPE_WCDMA_GSM_AUTO = "wcdma/gsm-auto";
> +this.GECKO_PREFERRED_NETWORK_TYPE_CDMA_EvDo = "cdma/evdo";
> +this.GECKO_PREFERRED_NETWORK_TYPE_CDMA_ONLY = "cdma";
> +this.GECKO_PREFERRED_NETWORK_TYPE_EvDo_ONLY = "evdo";

Let's use capital characters here to make the naming consistent. Thanks :)

@@ +348,5 @@
>    GECKO_PREFERRED_NETWORK_TYPE_WCDMA_GSM,
>    GECKO_PREFERRED_NETWORK_TYPE_GSM_ONLY,
> +  GECKO_PREFERRED_NETWORK_TYPE_WCDMA_ONLY,
> +  GECKO_PREFERRED_NETWORK_TYPE_WCDMA_GSM_AUTO,
> +  GECKO_PREFERRED_NETWORK_TYPE_CDMA_EvDo,

ditto.

Comment 3

[Ken Chang[:kenkai]]

Attachment: Use capital characters

Comment 4

[Hsin-Yi Tsai (she/her) | away [:hsinyi]]

Comment on attachment 705773 [details] [diff] [review]
Use capital characters

Review of attachment 705773 [details] [diff] [review]:
-----------------------------------------------------------------

r+ already, so you don't have to ask for the 2nd review. You are always welcome if you are not sure about your patch, though :)

Comment 5

[Ken Chang[:kenkai]]

Comment on attachment 705773 [details] [diff] [review]
Use capital characters

Put the checkin-needed keyword

Comment 6

[Hsin-Yi Tsai (she/her) | away [:hsinyi]]

Comment on attachment 705773 [details] [diff] [review]
Use capital characters

https://hg.mozilla.org/integration/mozilla-inbound/rev/7f0e88c3339b

Comment 7

[Hsin-Yi Tsai (she/her) | away [:hsinyi]]

Ken, please remember to add 'r=xxx' in the commit comment next time! :)

Comment 8

[Ryan VanderMeulen [:RyanVM]]

And please remove checkin-needed when you push.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7f0e88c3339b