Last Comment Bug 834118 - B2G CDMA: Add CDMA network type in the function of setting preferred network type.
: B2G CDMA: Add CDMA network type in the function of setting preferred network ...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM: Device Interfaces (show other bugs)
: unspecified
: ARM Gonk (Firefox OS)
: -- normal (vote)
: mozilla21
Assigned To: Ken Chang[:ken]
:
Mentors:
Depends on:
Blocks: 881862
  Show dependency treegraph
 
Reported: 2013-01-23 19:48 PST by Ken Chang[:ken]
Modified: 2013-06-13 21:14 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Add CDMA and EVDO network type (1.84 KB, patch)
2013-01-23 20:04 PST, Ken Chang[:ken]
htsai: review+
Details | Diff | Review
Use capital characters (1.84 KB, patch)
2013-01-24 01:00 PST, Ken Chang[:ken]
htsai: review+
htsai: checkin+
Details | Diff | Review

Description Ken Chang[:ken] 2013-01-23 19:48:08 PST
We only support WCDMA and GSM network types in the function of setting preferred network type. For CDMA, we have to add CDMA network type in that function.
Comment 1 Ken Chang[:ken] 2013-01-23 20:04:39 PST
Created attachment 705712 [details] [diff] [review]
Add CDMA and EVDO network type
Comment 2 Hsin-Yi Tsai [:hsinyi] 2013-01-23 22:12:21 PST
Comment on attachment 705712 [details] [diff] [review]
Add CDMA and EVDO network type

Review of attachment 705712 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the comments addressed :)

::: dom/system/gonk/ril_consts.js
@@ +340,5 @@
>  this.GECKO_PREFERRED_NETWORK_TYPE_WCDMA_ONLY = "wcdma";
> +this.GECKO_PREFERRED_NETWORK_TYPE_WCDMA_GSM_AUTO = "wcdma/gsm-auto";
> +this.GECKO_PREFERRED_NETWORK_TYPE_CDMA_EvDo = "cdma/evdo";
> +this.GECKO_PREFERRED_NETWORK_TYPE_CDMA_ONLY = "cdma";
> +this.GECKO_PREFERRED_NETWORK_TYPE_EvDo_ONLY = "evdo";

Let's use capital characters here to make the naming consistent. Thanks :)

@@ +348,5 @@
>    GECKO_PREFERRED_NETWORK_TYPE_WCDMA_GSM,
>    GECKO_PREFERRED_NETWORK_TYPE_GSM_ONLY,
> +  GECKO_PREFERRED_NETWORK_TYPE_WCDMA_ONLY,
> +  GECKO_PREFERRED_NETWORK_TYPE_WCDMA_GSM_AUTO,
> +  GECKO_PREFERRED_NETWORK_TYPE_CDMA_EvDo,

ditto.
Comment 3 Ken Chang[:ken] 2013-01-24 01:00:14 PST
Created attachment 705773 [details] [diff] [review]
Use capital characters
Comment 4 Hsin-Yi Tsai [:hsinyi] 2013-01-24 01:53:46 PST
Comment on attachment 705773 [details] [diff] [review]
Use capital characters

Review of attachment 705773 [details] [diff] [review]:
-----------------------------------------------------------------

r+ already, so you don't have to ask for the 2nd review. You are always welcome if you are not sure about your patch, though :)
Comment 5 Ken Chang[:ken] 2013-01-24 02:08:28 PST
Comment on attachment 705773 [details] [diff] [review]
Use capital characters

Put the checkin-needed keyword
Comment 6 Hsin-Yi Tsai [:hsinyi] 2013-01-24 02:33:23 PST
Comment on attachment 705773 [details] [diff] [review]
Use capital characters

https://hg.mozilla.org/integration/mozilla-inbound/rev/7f0e88c3339b
Comment 7 Hsin-Yi Tsai [:hsinyi] 2013-01-24 02:34:31 PST
Ken, please remember to add 'r=xxx' in the commit comment next time! :)
Comment 8 Ryan VanderMeulen [:RyanVM] 2013-01-24 07:13:37 PST
And please remove checkin-needed when you push.
Comment 9 Ryan VanderMeulen [:RyanVM] 2013-01-24 09:45:35 PST
https://hg.mozilla.org/mozilla-central/rev/7f0e88c3339b

Note You need to log in before you can comment on or make changes to this bug.