B2G CDMA: Add CDMA network type in the function of setting preferred network type.

RESOLVED FIXED in mozilla21

Status

()

Core
DOM: Device Interfaces
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: kenkai, Assigned: kenkai)

Tracking

unspecified
mozilla21
ARM
Gonk (Firefox OS)
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
We only support WCDMA and GSM network types in the function of setting preferred network type. For CDMA, we have to add CDMA network type in that function.
(Assignee)

Comment 1

4 years ago
Created attachment 705712 [details] [diff] [review]
Add CDMA and EVDO network type
Attachment #705712 - Flags: review?(htsai)
Comment on attachment 705712 [details] [diff] [review]
Add CDMA and EVDO network type

Review of attachment 705712 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the comments addressed :)

::: dom/system/gonk/ril_consts.js
@@ +340,5 @@
>  this.GECKO_PREFERRED_NETWORK_TYPE_WCDMA_ONLY = "wcdma";
> +this.GECKO_PREFERRED_NETWORK_TYPE_WCDMA_GSM_AUTO = "wcdma/gsm-auto";
> +this.GECKO_PREFERRED_NETWORK_TYPE_CDMA_EvDo = "cdma/evdo";
> +this.GECKO_PREFERRED_NETWORK_TYPE_CDMA_ONLY = "cdma";
> +this.GECKO_PREFERRED_NETWORK_TYPE_EvDo_ONLY = "evdo";

Let's use capital characters here to make the naming consistent. Thanks :)

@@ +348,5 @@
>    GECKO_PREFERRED_NETWORK_TYPE_WCDMA_GSM,
>    GECKO_PREFERRED_NETWORK_TYPE_GSM_ONLY,
> +  GECKO_PREFERRED_NETWORK_TYPE_WCDMA_ONLY,
> +  GECKO_PREFERRED_NETWORK_TYPE_WCDMA_GSM_AUTO,
> +  GECKO_PREFERRED_NETWORK_TYPE_CDMA_EvDo,

ditto.
Attachment #705712 - Flags: review?(htsai) → review+
(Assignee)

Comment 3

4 years ago
Created attachment 705773 [details] [diff] [review]
Use capital characters
Attachment #705773 - Flags: review?(htsai)
Comment on attachment 705773 [details] [diff] [review]
Use capital characters

Review of attachment 705773 [details] [diff] [review]:
-----------------------------------------------------------------

r+ already, so you don't have to ask for the 2nd review. You are always welcome if you are not sure about your patch, though :)
Attachment #705773 - Flags: review?(htsai) → review+
(Assignee)

Comment 5

4 years ago
Comment on attachment 705773 [details] [diff] [review]
Use capital characters

Put the checkin-needed keyword
Attachment #705773 - Flags: checkin?
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
Comment on attachment 705773 [details] [diff] [review]
Use capital characters

https://hg.mozilla.org/integration/mozilla-inbound/rev/7f0e88c3339b
Attachment #705773 - Flags: checkin? → checkin+
Attachment #705712 - Attachment is obsolete: true
Ken, please remember to add 'r=xxx' in the commit comment next time! :)
And please remove checkin-needed when you push.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/7f0e88c3339b
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
Blocks: 881862
You need to log in before you can comment on or make changes to this bug.