834207 - [Settings] In Phone lock password screen, one letter is visible when click 'create' button

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Leo]

1. Title : In Phone lock password screen, one letter is visible when click 'create' button
2. Precondition : 
3. Tester's Action : settings - phone lock - passcode lock on - input passcode - Create
4. Detailed Symptom (ENG.) : When click 'create'' button, "Create Passc..." string chang to "Create Passco..."
6. Expected : 
7. Reproducibility: Y
1)Frequency Rate : 100%
8. Gaia revision : 7b8dea7e7ec377a2143151bbe5e9998d87f7b36d

Comment 1

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Attachment: Pull Request #9140 - Fix menu button width changing behavior

Setting a fixed width to the menu item seemed to be the only way to fix this behavior, without making any changes to headers.css.

Comment 2

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 736763 [details]
Pull Request #9140 - Fix menu button width changing behavior

r=me if you have considered/tested on other screen size.

Comment 3

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

(In reply to Alive Kuo [:alive] from comment #2)
> Comment on attachment 736763 [details]
> Pull Request #9140 - Fix menu button width changing behavior
> 
> r=me if you have considered/tested on other screen size.

Thanks for the review, Alive, I updated the commit message; feel free to merge it to master. Thanks!

I have tested my changes against different language labels (i.e. for different localization settings) and also screen sizes (small and large).

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

https://github.com/mozilla-b2g/gaia/commit/287dd8fcb45bf021e609b45124c3a6672ec68e03