834219 - [Captive Portal] Squash the notifications in the same captive portal

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[(inactive after 6/18) Alive Kuo [:alive]]

Attachment: snapshot of many notifications

See snapshot.

I found this when I put my device on the desk and left for a while.
Theres notifications are about the same wifi, which should stack there to an amazing amount if I don't notice them. (100+ notifications expected....)

This is very bad.

schien, we should talk and figure out if we could limit the numbers of mozChromeEvent from gecko or we should block the notifications from gaia.

Comment 1

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Looks like the wifi is disconnected and connected for every few minutes. :(

There should be at most 1 notification for captive portal login. Gecko will send |captive-portal-login-abort| event to gaia for removing notification. I see code already land on shira branch and I'm not sure if these code works correctly on your test environment. ( https://github.com/mozilla-b2g/gaia/blob/shira/apps/system/js/captive_portal.js#L41 )

Comment 2

[Joe Cheng [:jcheng] (please needinfo)]

triage: qawanted to confirm on the pvtbuilds

Comment 3

[(inactive after 6/18) Alive Kuo [:alive]]

820288, 820279 is landed on v1-train so need QA's love from tomorrow on ;)

Comment 4

[Joe Cheng [:jcheng] (please needinfo)]

Want to make sure everyone knows that Shira is targeting 2/15 code freeze. 
Shira+ bugs needs more attention for unassigned, needinfo?,  review?
Full regression test is planned on 2/6. Need to have shira+ bugs landed by the end of 2/5 to be covered in full regression testing. Thanks

Comment 5

[(inactive after 6/18) Alive Kuo [:alive]]

I don't see this these days..make shira? and if so WFM.

Comment 6

[Joe Cheng [:jcheng] (please needinfo)]

shira-, please renom if reproducible.

Comment 7

[(inactive after 6/18) Alive Kuo [:alive]]

This happens again when I brought the device with me back on holiday.
And I find reproducible steps:
1. Turn on wifi
2. Choose an AP w/ captive portal
3. Press power button
4. Press Again
5. On lockscreen, long press power button.
6. Turn on airplane mode
7. Long press power button and turn off airplane mode.

You will see 2 notifications are there on lockscreen.
Turn on/off airplane mode is simulating the condition that AP is connected and disconnected.

Confirmed this is a gaia bug. Patch coming.

Comment 8

[(inactive after 6/18) Alive Kuo [:alive]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/8153

Patch v1:
Also remove notification node on lockscreen if possible.

Comment 9

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 715015 [details]
https://github.com/mozilla-b2g/gaia/pull/8153

r+ with nit.

Comment 10

[(inactive after 6/18) Alive Kuo [:alive]]

Master https://github.com/mozilla-b2g/gaia/commit/22dd34c27c6621070d4ae1a0caf911aaf75ac0c9
v1-train https://github.com/mozilla-b2g/gaia/commit/0b7cfe94ef5931ad4eae89542a99d546d42177a1

Comment 11

[(inactive after 6/18) Alive Kuo [:alive]]

v1.0.1 https://github.com/mozilla-b2g/gaia/commit/dad3bc82b1b705cd26711e3b77185adad1295973

Comment 12

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Alive, this only removes the notifications.  Is there a bug that you created as follow up to see why the wifi is disconnecting and reconnecting?  I seeing what :schien noted in comment 1.

Comment 13

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Naoki Hirata :nhirata from comment #12)
> Alive, this only removes the notifications.  Is there a bug that you created
> as follow up to see why the wifi is disconnecting and reconnecting?  I
> seeing what :schien noted in comment 1.

You could create a new bug for that :)

Comment 14

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Thanks Alive.  Created bug 843786.

Removing qawanted as this is already in the 1.0.1 build.

Comment 15

[John Ford [:jhford] CET/CEST Berlin Time]

per comment 10&11, this is fixed on v1-train and v1.0.1

Comment 16

[Askeing Yen[:askeing][:fyen]]

Unagi
Gaia:     819afb8758de9fbf87eca837e328818de93307ec
Gecko:    http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/96f559f949bb
BuildID   20130402230203
Version   18.0

Verified.