834228 - No symbols for XUL for Mac nightly

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Comment 1

[(not currently active) Ted Mielczarek]

There were two nightlies yesterday, the second one has no XUL symbols:
[[e-mail]1 symbols_ffx]$ grep XUL firefox-21.0a1-Darwin-20130123030907-x86-macosx64-symbols.txt
XUL/BC35ED9171C43B4AA6418E1DE66583FD0/XUL.sym
XUL/D8F5C84291053C89A7CC1D130FF3964F0/XUL.sym
XUL/D8F5C84291053C89A7CC1D130FF3964F0/XUL.dSYM.tar.bz2

[[e-mail]1 symbols_ffx]$ grep XUL firefox-21.0a1-Darwin-20130123052720-x86-macosx64-symbols.txt
[[e-mail]1 symbols_ffx]$

glandium notes that we seem to be missing symbols for all application binaries, we only picked up symbols from things in the test package. Almost certainly packager fallout.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Force a stage-package to run before buildsymbols on universal builds

I'm testing this on try:
https://tbpl.mozilla.org/?tree=Try&rev=5f26958696e4

Comment 3

[Mike Hommey [:glandium]]

Attachment: Force a stage-package to run before buildsymbols on universal builds

https://tbpl.mozilla.org/?tree=Try&rev=c45c7dcbbb57

Comment 4

[(not currently active) Ted Mielczarek]

Comment on attachment 705905 [details] [diff] [review]
Force a stage-package to run before buildsymbols on universal builds

Review of attachment 705905 [details] [diff] [review]:
-----------------------------------------------------------------

::: python/mozbuild/mozpack/files.py
@@ +138,5 @@
>      (see mozpack.executables.is_executable documentation).
>      '''
>      def copy(self, dest):
>          assert isinstance(dest, basestring)
> +        File.copy(self, dest)

Why is this needed?

Comment 5

[Mike Hommey [:glandium]]

(In reply to Ted Mielczarek [:ted.mielczarek] from comment #4)
> Why is this needed?

See the patch header :)

Comment 6

[(not currently active) Ted Mielczarek]

Ah, thanks!

Comment 7

[Mike Hommey [:glandium]]

Attachment: Force a stage-package to run before buildsymbols on universal builds

This disables elfhack and strip in l10n-repacks and unpack.

Comment 8

[(not currently active) Ted Mielczarek]

Comment on attachment 705945 [details] [diff] [review]
Force a stage-package to run before buildsymbols on universal builds

Review of attachment 705945 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/mozapps/installer/l10n-repack.py
@@ +187,5 @@
>                          help='Extra files not to be considered as resources')
>      args = parser.parse_args()
>  
> +    buildconfig.substs['USE_ELF_HACK'] = False
> +    buildconfig.substs['PKG_SKIP_STRIP'] = True

This feels a little hacky. Do you think it's worth cleaning up in a followup?

Comment 9

[Mike Hommey [:glandium]]

Attachment: Additional patch for proper PKG_SKIP_STRIP support

To whoever comes first.

Comment 10

[Gregory Szorc [:gps]]

Comment on attachment 706084 [details] [diff] [review]
Additional patch for proper PKG_SKIP_STRIP support

Review of attachment 706084 [details] [diff] [review]:
-----------------------------------------------------------------

Rubber stamp approved.

Comment 11

[Mike Hommey [:glandium]]

https://hg.mozilla.org/mozilla-central/rev/6420c37f6954

Comment 12

[Mike Hommey [:glandium]]

comm-central will need the flight.mk part of this patch.