Closed Bug 834228 Opened 8 years ago Closed 8 years ago

No symbols for XUL for Mac nightly

Categories

(Toolkit :: Crash Reporting, defect)

x86_64
macOS
defect
Not set
blocker

Tracking

()

RESOLVED FIXED
mozilla21

People

(Reporter: ted, Assigned: glandium)

References

Details

(Keywords: regression)

Attachments

(2 files, 2 obsolete files)

No description provided.
Blocks: new-packager
Severity: normal → blocker
There were two nightlies yesterday, the second one has no XUL symbols:
[tmielczarek@symbols1.dmz.phx1 symbols_ffx]$ grep XUL firefox-21.0a1-Darwin-20130123030907-x86-macosx64-symbols.txt
XUL/BC35ED9171C43B4AA6418E1DE66583FD0/XUL.sym
XUL/D8F5C84291053C89A7CC1D130FF3964F0/XUL.sym
XUL/D8F5C84291053C89A7CC1D130FF3964F0/XUL.dSYM.tar.bz2

[tmielczarek@symbols1.dmz.phx1 symbols_ffx]$ grep XUL firefox-21.0a1-Darwin-20130123052720-x86-macosx64-symbols.txt
[tmielczarek@symbols1.dmz.phx1 symbols_ffx]$

glandium notes that we seem to be missing symbols for all application binaries, we only picked up symbols from things in the test package. Almost certainly packager fallout.
Attachment #705839 - Flags: review?(ted) → review+
Attachment #705839 - Attachment is obsolete: true
Comment on attachment 705905 [details] [diff] [review]
Force a stage-package to run before buildsymbols on universal builds

Review of attachment 705905 [details] [diff] [review]:
-----------------------------------------------------------------

::: python/mozbuild/mozpack/files.py
@@ +138,5 @@
>      (see mozpack.executables.is_executable documentation).
>      '''
>      def copy(self, dest):
>          assert isinstance(dest, basestring)
> +        File.copy(self, dest)

Why is this needed?
Attachment #705905 - Flags: review?(ted) → review+
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #4)
> Why is this needed?

See the patch header :)
Ah, thanks!
This disables elfhack and strip in l10n-repacks and unpack.
Attachment #705945 - Flags: review?(ted)
Attachment #705905 - Attachment is obsolete: true
Comment on attachment 705945 [details] [diff] [review]
Force a stage-package to run before buildsymbols on universal builds

Review of attachment 705945 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/mozapps/installer/l10n-repack.py
@@ +187,5 @@
>                          help='Extra files not to be considered as resources')
>      args = parser.parse_args()
>  
> +    buildconfig.substs['USE_ELF_HACK'] = False
> +    buildconfig.substs['PKG_SKIP_STRIP'] = True

This feels a little hacky. Do you think it's worth cleaning up in a followup?
Attachment #705945 - Flags: review?(ted) → review+
To whoever comes first.
Attachment #706084 - Flags: review?(ted)
Attachment #706084 - Flags: review?(gps)
Comment on attachment 706084 [details] [diff] [review]
Additional patch for proper PKG_SKIP_STRIP support

Review of attachment 706084 [details] [diff] [review]:
-----------------------------------------------------------------

Rubber stamp approved.
Attachment #706084 - Flags: review?(ted)
Attachment #706084 - Flags: review?(gps)
Attachment #706084 - Flags: review+
Blocks: 834151
https://hg.mozilla.org/mozilla-central/rev/6420c37f6954
Target Milestone: --- → mozilla21
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
comm-central will need the flight.mk part of this patch.
Depends on: 835164
Depends on: 835214
You need to log in before you can comment on or make changes to this bug.