834292 - downloadapplied races window.close()

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

If an app update is downloaded while the app is in the foreground and then applied when the app calls window.close() to quit itself, the downloadapplied event is dispatched before the app is unloaded, such that the app receives that event if it is listening for it (and can momentarily react to it before it gets unloaded).

This seems like a minor issue, but it is nevertheless a race condition that shouldn't occur, as the app should be unloaded before its update is applied.

Over in bug 834074, @julienw notes: "We're listening for the "appwillclose" event, maybe another event (I believe we have "appclose" too) may be more suited but this is another bug anyway."

Comment 1

[Etienne Segonzac (:etienne)]

(In reply to Julien Wajsberg [:julienw] from comment #12 bug 834074)
> We're listening for the "appwillclose" event, maybe another event (I believe
> we have "appclose" too) may be more suited but this is another bug anyway.

Didn't found another event but the kill method on the window manager does take a callback, so looks like an easy fix :)

Comment 2

[Julien Wajsberg [:julienw] (PTO -> Jul 24)]

Seems like "appclose" was existing at one point (cf [1]) but using the callback seems better :)

[1] https://github.com/mozilla-b2g/gaia/issues/832

Comment 3

[BMO Automation]

Firefox OS is not being worked on