834323 - Consider to remove hardcoded samplerate from gstreamer pipeline.

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Oleg Romashin (:romaxa)]

I found one issue with gstreamer backend, that we have hardcoded rate value...
in that case if content does not match to that value, then gstreamer perform re-sampling which is kindof expensive...

I would suggest to remove that rate value from gst description.

Comment 1

[Oleg Romashin (:romaxa)]

Attachment: Remove hardcoded rate from gstreamer pipeline

Comment 2

[Ralph Giles (:rillian)]

Comment on attachment 705940 [details] [diff] [review]
Remove hardcoded rate from gstreamer pipeline

Patch does what you said it does, but I have no idea how safe this is. Passing review to Alessandro, the original author.

How many input sample rates have you tried? Does it work with 96 kHz? 8 kHz? 22.050?

Comment 3

[Oleg Romashin (:romaxa)]

I tried only 44100, and 48000

Comment 4

[Alessandro Decina]

Looks good: r+ (i don't have bugzilla powers to change the flag).

IIRC it was hardcoded to 44100 because that's what the downstream code was expecting at the time I wrote the original patch.

Comment 5

[cajbir (:cajbir)]

(In reply to Alessandro Decina from comment #4)
> Looks good: r+ (i don't have bugzilla powers to change the flag).

Do you get an error when you try? I checked that you have the correct permissions and you seem to.

Comment 6

[Ralph Giles (:rillian)]

(In reply to Chris Double (:doublec) from comment #5)

> Do you get an error when you try? I checked that you have the correct
> permissions and you seem to.

He should now. Gavin fixed the perms earlier today.

Comment 7

[Ryan VanderMeulen (PTO, back 6-April)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6e4f468b4906

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/6e4f468b4906